Fixed failing architecture tests

microsoft / MSIX-PackageSupportFramework

The Package Support Framework (PSF) is a kit for applying compatibility fixes to packaged desktop applications.

MIT License

114 stars 57 forks source link

Fixed failing architecture tests #192

Closed ravishroshanms closed 2 years ago

ravishroshanms commented 2 years ago

Detour fails due to an architecture mis-match. Trying the launch using PsfRunDll.

dhoehna commented 2 years ago

PSF should adopt RAII for handles and such.

Is this PR to close the resources?

ravishroshanms commented 2 years ago

We are using DetourProcessViaHelperDllsW API to launch the process using PsfRunDll when DetourUpdateProcessWithDll fails due to architecture mismatch. This change fixes the architecture tests which are failing in the develop currently. I agree that we should have RAII for handles, but right now I have handled them as they were being handled till now. Will take that up separately later.