microsoft / MixedReality-WebRTC

MixedReality-WebRTC is a collection of components to help mixed reality app developers integrate audio and video real-time communication into their application and improve their collaborative experience
https://microsoft.github.io/MixedReality-WebRTC/
MIT License
898 stars 277 forks source link

Linux build for m71 #824

Closed OlegKrymskyi closed 2 years ago

ghost commented 2 years ago

CLA assistant check
All CLA requirements met.

djee-ms commented 2 years ago

Hi @OlegKrymskyi, many thanks for opening this PR. I'll try to get some time to review it, but already I can tell by policy we're unlikely to be able to commit a prebuilt binary file (.so) into this repository, for security reasons. Can you please try to avoid it? Thanks!

OlegKrymskyi commented 2 years ago

Hi @OlegKrymskyi, many thanks for opening this PR. I'll try to get some time to review it, but already I can tell by policy we're unlikely to be able to commit a prebuilt binary file (.so) into this repository, for security reasons. Can you please try to avoid it? Thanks!

Yes, sure, I will remove this file. I hope in the next release version it will be a part of the nuget :)

joshdixon commented 2 years ago

Hey @OlegKrymskyi, I've been trying out your linux example and it seems to work until I try to use a TURN server. I get the following: image

Any ideas?

OlegKrymskyi commented 2 years ago

@joshdixon Try to run it with the same setting on windows. Do you have the same error?

OlegKrymskyi commented 2 years ago

@joshdixon Besides, you can try to check your TURN server first: https://webrtc.github.io/samples/src/content/peerconnection/trickle-ice/

joshdixon commented 2 years ago

@joshdixon Besides, you can try to check your TURN server first: https://webrtc.github.io/samples/src/content/peerconnection/trickle-ice/

Yep you're right, was an issue with the TURN server. Cheers for the swift reply!

djee-ms commented 2 years ago

Closing PR ahead of disabling, as per Microsoft Mixed Reality organization decision.