search

microsoft / TextWorld

​TextWorld is a sandbox learning environment for the training and evaluation of reinforcement learning (RL) agents on text-based games.
Other
1.22k stars 187 forks source link

Get admissible commands in Jericho environments #308

Closed robinbg closed 1 year ago

robinbg commented 1 year ago

Support return admissible commands in Jericho environments

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@e5e5640). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head c84ad4e differs from pull request most recent head d4737ca. Consider uploading reports for the commit d4737ca to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #308   +/-   ##
=======================================
  Coverage        ?   84.09%           
=======================================
  Files           ?       58           
  Lines           ?     7760           
  Branches        ?        0           
=======================================
  Hits            ?     6526           
  Misses          ?     1234           
  Partials        ?        0
MarcCote commented 1 year ago

@robinbg thanks for the PR. I had a similar change in a local branch. Do you get any warnings when loading a tw-*.z8 games (i.e., game generated with tw-make)?

Also, can you add a unit test for this. For instance, dynamically downloading Zork1 from https://archive.org/download/Zork1Release88Z-machineFile/zork1.z5 and trying to retrieve the admissible commands for that game.

Edit:, I need to check into the issue with MacOS. Probably some dependencies that broke recently.