Compilation errors in EffectEditor - Githubissues

microsoft / WindowsCompositionSamples

The Windows Composition Samples have moved here: https://github.com/microsoft/WindowsAppSDK-Samples/tree/main/Samples/SceneGraph

https://github.com/microsoft/WindowsAppSDK-Samples/tree/main/Samples/SceneGraph

MIT License

1.13k stars 287 forks source link

Compilation errors in EffectEditor #300

Closed hansmbakker closed 6 years ago

hansmbakker commented 6 years ago

Issue Type

[*] Bug Report

Current Behavior

The EffectEditor solution cannot be compiled because:

the SamplesNative project is not included but SamplesCommon depends on it (fixed in https://github.com/Microsoft/WindowsCompositionSamples/pull/301)
there are types referenced in https://github.com/Microsoft/WindowsCompositionSamples/blob/master/Demos/EffectEditor/MainPage.xaml.cs#L111 that are not defined in the rest of the repo

Expected Behavior

Compiling code in the master branch

Steps to Reproduce (for bugs)

Checkout this repo
Open EffectEditor solution
Retarget SDK to build 17763
Build solution

Your Environment

SDK #: 17763
Operating System build # : 17763
Visual Studio Version # : 15.9 Preview 3

daneuber commented 6 years ago

Fixed by #301