search

microsoft / WindowsCompositionSamples

The Windows Composition Samples have moved here: https://github.com/microsoft/WindowsAppSDK-Samples/tree/main/Samples/SceneGraph
https://github.com/microsoft/WindowsAppSDK-Samples/tree/main/Samples/SceneGraph
MIT License
1.12k stars 287 forks source link

Some details fix #370

Closed HO-COOH closed 5 months ago

HO-COOH commented 6 months ago

Pull Request Type

[x] Bugfix <!—Please add link to related Issue below -->
[ ] New Sample
[ ] Other - Please describe:

Issue

Proposed Changes

Screenshot/GIF (if applicable):

jeffstall commented 5 months ago

Can you actually migrate this to https://github.com/microsoft/WindowsAppSDK-Samples instead? We're in the process of consolidating repos to simplify things. This repo will be archived.

HO-COOH commented 5 months ago

@jeffstall I didn't see composition gallery's code anywhere in that repo. Maybe first update your contribution guide?

jeffstall commented 5 months ago

Hi @HO-COOH,

Thank-you for helping to make our samples better. Honestly, I really appreciate the help! Yes, we've been a little busy with cleaning everything up as part of Build 2024 and follow-up WinUI Community Call, which we just had this morning. The Compositions samples are here.

I have a list of things that we're working through on cleaning up and consolidating multiple repos together to make it much easier for Windows app development. I'm working with a few people in the process of cleaning up this repo, and we're getting ready to post updates in a week or two. I appreciated your fix, and I didn't want it to get lost in the process. 😅

Thanks for helping! ~ Jeffrey

HO-COOH commented 5 months ago

@jeffstall Sure. I just happened to look into Composition a lot lately. You can close it after your repo migration ready and I can resubmit them. I have some other features I want to contribute as well, and I will hold it back for now.

jeffstall commented 5 months ago

We're archiving this repo and have moved everything to https://github.com/microsoft/WindowsAppSDK-Samples/tree/main/Samples/SceneGraph instead.