microsoft / azure-gradle-plugins

Azure Plugins for Gradle
MIT License
45 stars 28 forks source link

Fix for issue #166 - make allowTelemetry option to work #169

Closed enaess closed 1 year ago

enaess commented 1 year ago

I've tested this two ways:

Also moved the mergeCommandLineParameters() function to execute prior to the check for allowTelemetry allowing the property to be set.

Display the disclaimer of privacy statement to only when allowTelemetry is evaluated to true, which is still the default.

enaess commented 1 year ago

@microsoft-github-policy-service agree company="Absolute"

enaess commented 1 year ago

@microsoft-github-policy-service agree company="Absolute"

enaess commented 1 year ago

Could you please give this a review @Flanker32?

enaess commented 1 year ago

@wangmingliang-ms could you please give this a review?

Flanker32 commented 1 year ago

@enaess Thanks a lot for your efforts and sorry for the late response. We will release the fix asap