search

microsoft / botframework-solutions

Welcome to the Bot Framework Solutions repository which is the home for a set of templates and solutions to help build advanced conversational experiences using Azure Bot Service and Bot Framework. Microsoft Bot Framework is a comprehensive framework for building enterprise-grade conversational AI experiences.
https://aka.ms/bfsolutionsdocs
MIT License
1.05k stars 528 forks source link

Add AADv1 support to OauthProvider #1386

Closed siddimore closed 5 years ago

siddimore commented 5 years ago

Is your feature request related to a problem? Please describe. Skill i work uses AAD v1 for Oauth. Currently Microsoft.bot.solutions only support AADv2

Describe the solution you'd like Add support for AADv1 in MultiproviderAuthDialog

siddimore commented 5 years ago

Please change the below: switch (providerString) { case "Azure Active Directory": case "Azure Active Directory v2": return OAuthProvider.AzureAD;

darrenj commented 5 years ago

Resolved by #1387

Will this get pushed as part of our daily build to myget @lzc850612 ?

xieofxie commented 5 years ago

Will we add enums for all providers in azure (like Generic Oauth 2, Oauth 2 Generic Provider etc.)? Or it will be revised in later release.