search

microsoft / cascadia-code

This is a fun, new monospaced font that includes programming ligatures and is designed to enhance the modern look and feel of the Windows Terminal.
Other
26.07k stars 810 forks source link

o-my-posh theme slightly broken #766

Open imSamiul opened 2 months ago

imSamiul commented 2 months ago

Cascadia family version

2404.23

Cascadia family variant(s)

Cascadia Code (the version with ligatures)

Font file format(s)

.ttf (variable)

Platform

Windows

Other Software

Windows Terminal

What happened?

Screenshot 2024-09-02 135205 Here o-my-posh theme icon is slightly broken on new released Cascadia Code 2404.23 Nerd Font.

o-l-a-v commented 2 months ago

Do you have an example of a font where it's not broken like that?

imSamiul commented 2 months ago

Do you have an example of a font where it's not broken like that?

Fira Code Nerd Font Mono

image

@o-l-a-v

o-l-a-v commented 2 months ago

I can't reproduce. Tried Cascadia Mono NF and Cascadia Code NF.

image
imSamiul commented 2 months ago

@o-l-a-v it gets fixed when the font size increased. Try using lower the font size of windows terminal then use get-PoshThemes. some themes are broken. to be specific when the font size is 12

o-l-a-v commented 2 months ago

I used font size 12 in those screenshots and zoomed in. I also tried Get-PoshThemes. I can't reproduce with the steps you've provided. So maybe you should do some more research into what conditions causes this.

aaronbell commented 2 months ago

Not to say that there isn’t something else going on here, but it is challenging to identify exactly the problem due to the differing factors involved. Namely the way that a given rendering environment implements the highlighting, the way the OS text rasterizer positions the end cap, the resolution of your monitor, zoom amount, etc etc.

I think that the next version of Cascadia will sort this out but hard to say for certain.

imSamiul commented 2 months ago

My problem is kind of wierd. My themes get broken only on even number of font size like 10,12,14... 16 is good. don't know what happed. 11,13,15 are good. hard to find out the problem. I use windows 11, my laptop resolution is 1920x1080 with 125% zoom 15.6 inch display. maybe it pixer rendering issue. not sure. any information that you need i can provide. Hope for the better version of Cascadia.

aaronbell commented 2 months ago

Yeah, that’s kind of how this thing goes. Some sizes are perfect, others aren’t. Hard to predict!

DHowett commented 2 months ago

It is worth noting that new versions of Windows Terminal (1.20 and above) take over the following powerline shapes, and draw them "perfectly". This means that if you are using Cascadia with these versions Windows Terminal, you should not experience rounding errors like this.

Image