[CoE Starter Kit - BUG] Parse Flow JSON issue with SYNC HELPER - Cloud Flows

bhavikj65 commented 1 year ago

Does this bug already exist in our backlog?

[X] I have checked and confirm this is a new bug.

Describe the issue

The Parse Flow JSON action within "SYNC HELPER - Cloud Flows" flow fails for some cloud flows and below is the error message:

InternalServerError. Encountered internal server error. The tracking Id is '02428134-b28a-4e55-86dc-5388f4744cbd'.

I worked with Microsoft Support, and they checked telemetry logs and found below error:

Newtonsoft.Json.JsonReaderException: The reader's MaxDepth of 64 has been exceeded. Path 'properties.definition.actions.Parse_JSON_Tech.inputs.schema.properties.properties.properties.properties.properties.properties.properties.properties.properties.properties.properties.properties.properties.properties.properties.Options.properties.properties.properties.properties.properties.properties.properties.items.properties.properties.properties.properties.properties.properties.properties.properties.properties.properties.properties.properties.properties.properties.properties.Label.properties.properties.properties.properties.properties.properties.properties.properties.properties.properties.properties.properties.properties.properties.properties.LocalizedLabels.properties.type'.

We tested this with a new flow where we got output of Get Flow as Admin and used the same Parse JSON action and found the same error. We then only parsed the actions & triggers as input to the Parse JSON action and that seems to wok fine.

Expected Behavior

Parse Flow JSON action within SYNC HELPER - CLoud Flows should work fine. If it fails, I think the error should be handled and maybe Parse JSON action should be optimized by creating multiple actions and passing different properties as inputs for example:

What solution are you experiencing the issue with?

Core

What solution version are you using?

4.8

What app or flow are you having the issue with?

SYNC HELPER - Cloud Flows

What method are you using to get inventory and telemetry?

Cloud flows

Steps To Reproduce

There is no repro for this as it only seems to fail for cloud flows which returns larger JSON response in Get Flow as Admin action.

Anything else?

No response

Jenefer-Monroe commented 1 year ago

We cannot only parse those sections, we need to be able to parse the whole flow, so this is something that we would need to address with the product team.

Can you confirm:

You are saying this one repros for a small subset of your flows correct? I have not seen this before so double checking.
Are you using some localized labels feature explicitly? Or is that property a mystery to you as well?

bhavikj65 commented 1 year ago

We are seeing this only for 2 cloud flows so far and I remember the Microsoft Support engineer mentioning about localized labels so one of this flow has it. While checking output of the Get Flow as Admin for that affected flow, I could see below as localized labels:

"Description": { "type": "object", "properties": { "LocalizedLabels": { "type": "array", "items": { "type": "object", "properties": { "Label": { "type": "string" }, "LanguageCode": { "type": "integer" }, "IsManaged": { "type": "boolean" }, "MetadataId": { "type": "string" }, "HasChanged": {} }, "required": [ "Label", "LanguageCode", "IsManaged", "MetadataId", "HasChanged" ] }

Jenefer-Monroe commented 1 year ago

Chatted with my counterpart and do think we could work around this but it would mean more API calls so want to make sure that woudl be justified here. Do you know how the flow got that feature introduced?

bhavikj65 commented 1 year ago

I am not owner of the cloud flow and hence not sure how that feature got added there.

If you have specific questions, I could ask the flow owner.

Thank you, Bhavik

On Tue, 4 Jul, 2023, 9:46 pm Jenefer Monroe, @.***> wrote:

Chatted with my counterpart and do think we could work around this but it would mean more API calls so want to make sure that woudl be justified here. Do you know how the flow got that feature introduced?

— Reply to this email directly, view it on GitHub https://github.com/microsoft/coe-starter-kit/issues/5996#issuecomment-1620502089, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZFSONRQCGMCQWFJDQWS4GLXOQ6UHANCNFSM6AAAAAAZ55EEUA . You are receiving this because you authored the thread.Message ID: @.***>

Jenefer-Monroe commented 1 year ago

I supposed you can just ask them if they are using some kind of localization feature in the flow.

bhavikj65 commented 1 year ago

I asked flow owner and he confirmed that he hasn't used any localization features, have asked him to share the flow with me to check.

Jenefer-Monroe commented 1 year ago

Placing on backlog for consideration

microsoft / coe-starter-kit