microsoft / design-to-code

A system of development tools, and utilities used à la carte or as a suite to build enterprise-grade websites and applications.
MIT License
24 stars 6 forks source link

add workspaces flag in package not yml #117

Closed awentzel closed 2 years ago

awentzel commented 2 years ago

Pull Request

📖 Description

Moves --workspaces flag to package.json file under script publish-ci instead so that it runs as part of what's passed into npm not beachball as a command.

🎫 Issues

Workspaces doesn't work in GH Actions because it's out of order. I remember Beachball being very particular with where the arguments lives and this causes a different build break.

  shell: /usr/bin/bash -e {0}
  env:
    GITHUB_TOKEN: ***
    GITHUB_SERVICE_USER: FAST DevOps
    GITHUB_SERVICE_EMAIL: fastsvc@microsoft.com
    NPM_SECRET_TOKEN: ***
npm ERR! Lifecycle script `publish-ci` failed with error: 
npm ERR! Error: Missing script: "publish-ci"

👩‍💻 Reviewer Notes

✅ Checklist

General

⏭ Next Steps