Fix purge history threshold check

microsoft / durabletask-mssql

Microsoft SQL storage provider for Durable Functions and the Durable Task Framework

MIT License

87 stars 32 forks source link

Fix purge history threshold check #39

Closed Jaah closed 3 years ago

Jaah commented 3 years ago

The documentation for PurgeOrchestrationHistoryAsync says it should be purging instances that are older than the given threshold. However it seems that the stored procedure used to retrieve these is currently retrieving instances newer than the given threshold.

This will PR fixes the PurgeInstanceStateByTime stored procedure to retrieve instances that are older than the given threshold time.

cgillum commented 3 years ago

Looks like we have some tests that assume the previous behavior that also need to be updated in order for the CI to pass.

ghost commented 3 years ago

All CLA requirements met.

cgillum commented 3 years ago

I went ahead and added the appropriate test updates to your PR. I also credited you with this contribution in the CHANGELOG. Thanks again!