search

microsoft / etl2pcapng

Utility that converts an .etl file containing a Windows network packet capture into .pcapng format.
MIT License
630 stars 114 forks source link

Shouldn't CMake be used as a build system? #25

Closed KOLANICH closed 3 years ago

KOLANICH commented 4 years ago

To make it easier building without VisualStudio.

maolson-msft commented 3 years ago

CMake has many benefits for cross-platform building, but since etl2pcapng calls APIs that are not likely to ever be supported on an OS other than Windows, those benefits are not relevant to this project. Using CMake, then, would just add CMake as a dependency for building (and you'd still have to install Visual Studio, if I understand correctly). So you'll have to run the one-line command found in the Building section in the readme.

KOLANICH commented 3 years ago

CMake has many benefits for cross-platform building, but since etl2pcapng calls APIs that are not likely to ever be supported on an OS other than Windows, those benefits are not relevant to this project.

It is not about cross-platform building. It is about not using Visual Studio - proprietary app with telemetry that cannot even be downloaded without sending telemetry.

I don't want to have that on my PC. I prefer GCC+MinGW and Clang 13+MinGW. Especially taking into account that GCC is one of the best (if not the best) optimizing compiler (see Agner Fog's articles for the benchmarks, though these articles may be a bit out of date).