search

microsoft / fabrikate

Making GitOps with Kubernetes easier one component at a time
MIT License
38 stars 5 forks source link

Fab add does not take generator as an argument #188

Closed samiyaakhtar closed 5 years ago

samiyaakhtar commented 5 years ago

Describe the bug: We're trying to run fab add to add new branches to the service HLD to accomplish rings, but generator is not an accepted argument so it takes the form of component which is default, when we would like to choose helm as the generator. 

2019-06-02T01:19:49.6306672Z fab add hello-rings-master --source https://github.com/bnookala/hello-rings --branch master --method git --path chart --generator helm
2019-06-02T01:19:49.6324713Z Error: unknown flag: --generator
2019-06-02T01:19:49.6327923Z Usage:
2019-06-02T01:19:49.6328879Z   fab add <component-name> --source <component-source> [--type component] [--method git] [--path .] [flags]
2019-06-02T01:19:49.6329308Z 
2019-06-02T01:19:49.6329514Z Flags:
2019-06-02T01:19:49.6330440Z       --branch string   Branch of git repo to use (default: master) (default "master")
2019-06-02T01:19:49.6330915Z   -h, --help            help for add
2019-06-02T01:19:49.6331420Z       --method string   Method to use to fetch this component (default: git) (default "git")
2019-06-02T01:19:49.6331971Z       --path string     Path of git repo to use (default: ./)
2019-06-02T01:19:49.6332440Z       --source string   Source for this component
2019-06-02T01:19:49.6333681Z       --type string     Type of this component (default: component) (default "component")
2019-06-02T01:19:49.6333998Z 
2019-06-02T01:19:49.6334229Z Global Flags:
2019-06-02T01:19:49.6334721Z       --verbose   Use verbose output logs
samiyaakhtar commented 5 years ago

Just realized type is equivalent to generator :)