DustyTheBot
commented
4 years ago | Warnings | |
|---|---|
| :warning: | There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR. |
| :warning: | 58 perf regressions detected |
Perf comparison
| Status | Scenario | Fluent TPI | Fabric TPI | Ratio | Iterations | Ticks |
|---|---|---|---|---|---|---|
| 🔧 | Avatar.Fluent | 0.55 | 0.39 | 1.41:1 | 2000 | 1103 |
| 🔧 | Button.Fluent | 1.19 | 0.16 | 7.44:1 | 1000 | 1190 |
| 🔧 | Checkbox.Fluent | 1.38 | 0.28 | 4.93:1 | 1000 | 1382 |
| 🔧 | Dialog.Fluent | 0.33 | 0.17 | 1.94:1 | 5000 | 1662 |
| 🔧 | Dropdown.Fluent | 3.32 | 0.37 | 8.97:1 | 1000 | 3324 |
| 🔧 | Icon.Fluent | 0.23 | 0.03 | 7.67:1 | 5000 | 1151 |
| 🔧 | Image.Fluent | 0.1 | 0.07 | 1.43:1 | 5000 | 491 |
| 🔧 | Slider.Fluent | 1.81 | 0.29 | 6.24:1 | 1000 | 1806 |
| 🔧 | Text.Fluent | 0.05 | 0.02 | 2.5:1 | 5000 | 230 |
| 🦄 | Tooltip.Fluent | 0.37 | 17.79 | 0.02:1 | 5000 | 1857 |
🔧 Needs work 🎯 On target 🦄 Amazing
Potential regressions comparing to master
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonMinimalPerf.default | 1236 | 119 | 10.39:1 |
| Button.Fluent | 1190 | 134 | 8.88:1 |
| IconMinimalPerf.default | 1012 | 273 | 3.71:1 |
| StatusMinimalPerf.default | 819 | 269 | 3.04:1 |
| ButtonSlotsPerf.default | 1605 | 602 | 2.67:1 |
| ListMinimalPerf.default | 656 | 265 | 2.48:1 |
| ImageMinimalPerf.default | 490 | 217 | 2.26:1 |
| Image.Fluent | 491 | 233 | 2.11:1 |
| Tooltip.Fluent | 1857 | 918 | 2.02:1 |
| Icon.Fluent | 1151 | 584 | 1.97:1 |
| LabelMinimalPerf.default | 1601 | 860 | 1.86:1 |
| TooltipMinimalPerf.default | 2130 | 1146 | 1.86:1 |
| CheckboxMinimalPerf.default | 6519 | 3639 | 1.79:1 |
| Checkbox.Fluent | 1382 | 890 | 1.55:1 |
| ListCommonPerf.default | 1030 | 682 | 1.51:1 |
| Slider.Fluent | 1806 | 1356 | 1.33:1 |
| AvatarMinimalPerf.default | 611 | 487 | 1.25:1 |
| SliderMinimalPerf.default | 1819 | 1463 | 1.24:1 |
| DropdownManyItemsPerf.default | 491 | 421 | 1.17:1 |
| Avatar.Fluent | 1103 | 945 | 1.17:1 |
| PortalMinimalPerf.default | 249 | 215 | 1.16:1 |
| AccordionMinimalPerf.default | 194 | 177 | 1.1:1 |
| GridMinimalPerf.default | 857 | 781 | 1.1:1 |
| InputMinimalPerf.default | 963 | 917 | 1.05:1 |
| MenuButtonMinimalPerf.default | 1487 | 1428 | 1.04:1 |
| ReactionMinimalPerf.default | 2498 | 2410 | 1.04:1 |
| TextAreaMinimalPerf.default | 3010 | 2937 | 1.02:1 |
| ToolbarMinimalPerf.default | 697 | 681 | 1.02:1 |
| DialogMinimalPerf.default | 1614 | 1591 | 1.01:1 |
| FormMinimalPerf.default | 702 | 695 | 1.01:1 |
| TreeMinimalPerf.default | 848 | 843 | 1.01:1 |
| VideoMinimalPerf.default | 698 | 690 | 1.01:1 |
| Dialog.Fluent | 1662 | 1645 | 1.01:1 |
| AlertMinimalPerf.default | 535 | 537 | 1:1 |
| DividerMinimalPerf.default | 900 | 898 | 1:1 |
| MenuMinimalPerf.default | 1792 | 1801 | 1:1 |
| EmbedMinimalPerf.default | 5985 | 6023 | 0.99:1 |
| HeaderSlotsPerf.default | 1235 | 1250 | 0.99:1 |
| ItemLayoutMinimalPerf.default | 1627 | 1644 | 0.99:1 |
| AnimationMinimalPerf.default | 435 | 446 | 0.98:1 |
| AttachmentSlotsPerf.default | 3126 | 3235 | 0.97:1 |
| CarouselMinimalPerf.default | 1766 | 1823 | 0.97:1 |
| SplitButtonMinimalPerf.default | 11328 | 11675 | 0.97:1 |
| DropdownMinimalPerf.default | 3404 | 3531 | 0.96:1 |
| HeaderMinimalPerf.default | 403 | 421 | 0.96:1 |
| LayoutMinimalPerf.default | 491 | 514 | 0.96:1 |
| LoaderMinimalPerf.default | 2205 | 2304 | 0.96:1 |
| SegmentMinimalPerf.default | 1196 | 1247 | 0.96:1 |
| TableMinimalPerf.default | 563 | 584 | 0.96:1 |
| AttachmentMinimalPerf.default | 867 | 916 | 0.95:1 |
| FlexMinimalPerf.default | 317 | 339 | 0.94:1 |
| Dropdown.Fluent | 3324 | 3540 | 0.94:1 |
| HierarchicalTreeMinimalPerf.default | 737 | 792 | 0.93:1 |
| PopupMinimalPerf.default | 341 | 365 | 0.93:1 |
| Text.Fluent | 230 | 250 | 0.92:1 |
| BoxMinimalPerf.default | 205 | 226 | 0.91:1 |
| ChatMinimalPerf.default | 1582 | 1772 | 0.89:1 |
| TextMinimalPerf.default | 235 | 263 | 0.89:1 |
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio :--- | ---:| ---:| ---: ProviderMinimalPerf.default | [758](https://22956-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMinimalPerf.default.html) | [646](https://22956-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMinimalPerf.default_base.html) | 1.17:1 ProviderMergeThemesPerf.default | [1252](https://22956-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMergeThemesPerf.default.html) | [1135](https://22956-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMergeThemesPerf.default_base.html) | 1.1:1 RefMinimalPerf.default | [159](https://22956-141743704-gh.circle-artifacts.com/0/artifacts/perf/RefMinimalPerf.default.html) | [156](https://22956-141743704-gh.circle-artifacts.com/0/artifacts/perf/RefMinimalPerf.default_base.html) | 1.02:1 ChatDuplicateMessagesPerf.default | [530](https://22956-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatDuplicateMessagesPerf.default.html) | [527](https://22956-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatDuplicateMessagesPerf.default_base.html) | 1.01:1 ChatWithPopoverPerf.default | [571](https://22956-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatWithPopoverPerf.default.html) | [570](https://22956-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatWithPopoverPerf.default_base.html) | 1:1 RadioGroupMinimalPerf.default | [380](https://22956-141743704-gh.circle-artifacts.com/0/artifacts/perf/RadioGroupMinimalPerf.default.html) | [388](https://22956-141743704-gh.circle-artifacts.com/0/artifacts/perf/RadioGroupMinimalPerf.default_base.html) | 0.98:1 CustomToolbarPrototype.default | [3878](https://22956-141743704-gh.circle-artifacts.com/0/artifacts/perf/CustomToolbarPrototype.default.html) | [4082](https://22956-141743704-gh.circle-artifacts.com/0/artifacts/perf/CustomToolbarPrototype.default_base.html) | 0.95:1Generated by :no_entry_sign: dangerJS
Before:
After: