search

microsoft / fluent-ui-react

An ecosystem for building highly customizable enterprise class user interfaces.
https://aka.ms/fluent-ui
MIT License
433 stars 54 forks source link

fix(Animation): not to throw if children is not set #2345

Closed mnajdova closed 4 years ago

mnajdova commented 4 years ago

Fixes https://github.com/microsoft/fluent-ui-react/issues/2341

DustyTheBot commented 4 years ago

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.48 0.39 1.23:1 2000 951
🎯 Button.Fluent 0.13 0.17 0.76:1 1000 127
🔧 Checkbox.Fluent 0.79 0.28 2.82:1 1000 793
🔧 Dialog.Fluent 0.32 0.17 1.88:1 5000 1587
🔧 Dropdown.Fluent 3.31 0.35 9.46:1 1000 3310
🔧 Icon.Fluent 0.11 0.03 3.67:1 5000 573
🎯 Image.Fluent 0.05 0.07 0.71:1 5000 232
🔧 Slider.Fluent 1.37 0.31 4.42:1 1000 1369
🔧 Text.Fluent 0.06 0.02 3:1 5000 279
🦄 Tooltip.Fluent 0.14 17.94 0.01:1 5000 676

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions Scenario | Current PR Ticks | Baseline Ticks | Ratio :--- | ---:| ---:| ---: ProviderMergeThemesPerf.default | [1245](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMergeThemesPerf.default.html) | [1080](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMergeThemesPerf.default_base.html) | 1.15:1 SegmentMinimalPerf.default | [1394](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/SegmentMinimalPerf.default.html) | [1211](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/SegmentMinimalPerf.default_base.html) | 1.15:1 AccordionMinimalPerf.default | [208](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/AccordionMinimalPerf.default.html) | [185](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/AccordionMinimalPerf.default_base.html) | 1.12:1 ButtonMinimalPerf.default | [119](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonMinimalPerf.default.html) | [106](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonMinimalPerf.default_base.html) | 1.12:1 AnimationMinimalPerf.default | [516](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/AnimationMinimalPerf.default.html) | [463](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/AnimationMinimalPerf.default_base.html) | 1.11:1 DropdownManyItemsPerf.default | [457](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownManyItemsPerf.default.html) | [410](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownManyItemsPerf.default_base.html) | 1.11:1 SliderMinimalPerf.default | [1505](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/SliderMinimalPerf.default.html) | [1354](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/SliderMinimalPerf.default_base.html) | 1.11:1 PopupMinimalPerf.default | [361](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/PopupMinimalPerf.default.html) | [327](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/PopupMinimalPerf.default_base.html) | 1.1:1 InputMinimalPerf.default | [975](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/InputMinimalPerf.default.html) | [898](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/InputMinimalPerf.default_base.html) | 1.09:1 PortalMinimalPerf.default | [246](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/PortalMinimalPerf.default.html) | [226](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/PortalMinimalPerf.default_base.html) | 1.09:1 Text.Fluent | [279](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Text.Fluent.html) | [257](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Text.Fluent_base.html) | 1.09:1 AlertMinimalPerf.default | [645](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/AlertMinimalPerf.default.html) | [599](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/AlertMinimalPerf.default_base.html) | 1.08:1 HeaderMinimalPerf.default | [511](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderMinimalPerf.default.html) | [481](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderMinimalPerf.default_base.html) | 1.06:1 HeaderSlotsPerf.default | [1434](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderSlotsPerf.default.html) | [1348](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderSlotsPerf.default_base.html) | 1.06:1 CustomToolbarPrototype.default | [3761](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/CustomToolbarPrototype.default.html) | [3543](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/CustomToolbarPrototype.default_base.html) | 1.06:1 Tree60WithListItems.default | [215](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Tree60WithListItems.default.html) | [203](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Tree60WithListItems.default_base.html) | 1.06:1 Tooltip.Fluent | [676](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Tooltip.Fluent.html) | [635](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Tooltip.Fluent_base.html) | 1.06:1 BoxMinimalPerf.default | [222](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/BoxMinimalPerf.default.html) | [212](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/BoxMinimalPerf.default_base.html) | 1.05:1 AvatarMinimalPerf.default | [551](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/AvatarMinimalPerf.default.html) | [528](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/AvatarMinimalPerf.default_base.html) | 1.04:1 DialogMinimalPerf.default | [1660](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/DialogMinimalPerf.default.html) | [1591](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/DialogMinimalPerf.default_base.html) | 1.04:1 ReactionMinimalPerf.default | [2698](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ReactionMinimalPerf.default.html) | [2602](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ReactionMinimalPerf.default_base.html) | 1.04:1 TextMinimalPerf.default | [253](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextMinimalPerf.default.html) | [244](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextMinimalPerf.default_base.html) | 1.04:1 ImageMinimalPerf.default | [235](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ImageMinimalPerf.default.html) | [229](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ImageMinimalPerf.default_base.html) | 1.03:1 LabelMinimalPerf.default | [826](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/LabelMinimalPerf.default.html) | [801](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/LabelMinimalPerf.default_base.html) | 1.03:1 Icon.Fluent | [573](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Icon.Fluent.html) | [554](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Icon.Fluent_base.html) | 1.03:1 ListCommonPerf.default | [158](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListCommonPerf.default.html) | [155](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListCommonPerf.default_base.html) | 1.02:1 AttachmentSlotsPerf.default | [3449](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentSlotsPerf.default.html) | [3421](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentSlotsPerf.default_base.html) | 1.01:1 ChatMinimalPerf.default | [1688](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatMinimalPerf.default.html) | [1678](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatMinimalPerf.default_base.html) | 1.01:1 DropdownMinimalPerf.default | [3560](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownMinimalPerf.default.html) | [3515](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownMinimalPerf.default_base.html) | 1.01:1 FormMinimalPerf.default | [740](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/FormMinimalPerf.default.html) | [736](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/FormMinimalPerf.default_base.html) | 1.01:1 RadioGroupMinimalPerf.default | [430](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/RadioGroupMinimalPerf.default.html) | [427](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/RadioGroupMinimalPerf.default_base.html) | 1.01:1 CarouselMinimalPerf.default | [1830](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/CarouselMinimalPerf.default.html) | [1832](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/CarouselMinimalPerf.default_base.html) | 1:1 Dropdown.Fluent | [3310](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dropdown.Fluent.html) | [3324](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dropdown.Fluent_base.html) | 1:1 ChatDuplicateMessagesPerf.default | [524](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatDuplicateMessagesPerf.default.html) | [528](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatDuplicateMessagesPerf.default_base.html) | 0.99:1 SplitButtonMinimalPerf.default | [11497](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/SplitButtonMinimalPerf.default.html) | [11632](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/SplitButtonMinimalPerf.default_base.html) | 0.99:1 ToolbarMinimalPerf.default | [691](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ToolbarMinimalPerf.default.html) | [696](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ToolbarMinimalPerf.default_base.html) | 0.99:1 CheckboxMinimalPerf.default | [3507](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/CheckboxMinimalPerf.default.html) | [3592](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/CheckboxMinimalPerf.default_base.html) | 0.98:1 ItemLayoutMinimalPerf.default | [1760](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ItemLayoutMinimalPerf.default.html) | [1802](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ItemLayoutMinimalPerf.default_base.html) | 0.98:1 MenuMinimalPerf.default | [1995](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuMinimalPerf.default.html) | [2041](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuMinimalPerf.default_base.html) | 0.98:1 ProviderMinimalPerf.default | [546](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMinimalPerf.default.html) | [558](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMinimalPerf.default_base.html) | 0.98:1 TableMinimalPerf.default | [550](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/TableMinimalPerf.default.html) | [559](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/TableMinimalPerf.default_base.html) | 0.98:1 EmbedMinimalPerf.default | [6332](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/EmbedMinimalPerf.default.html) | [6549](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/EmbedMinimalPerf.default_base.html) | 0.97:1 ListMinimalPerf.default | [270](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListMinimalPerf.default.html) | [278](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListMinimalPerf.default_base.html) | 0.97:1 VideoMinimalPerf.default | [667](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/VideoMinimalPerf.default.html) | [691](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/VideoMinimalPerf.default_base.html) | 0.97:1 ChatWithPopoverPerf.default | [542](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatWithPopoverPerf.default.html) | [563](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatWithPopoverPerf.default_base.html) | 0.96:1 TreeMinimalPerf.default | [856](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/TreeMinimalPerf.default.html) | [888](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/TreeMinimalPerf.default_base.html) | 0.96:1 Button.Fluent | [127](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Button.Fluent.html) | [132](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Button.Fluent_base.html) | 0.96:1 Checkbox.Fluent | [793](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Checkbox.Fluent.html) | [826](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Checkbox.Fluent_base.html) | 0.96:1 TextAreaMinimalPerf.default | [2888](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextAreaMinimalPerf.default.html) | [3034](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextAreaMinimalPerf.default_base.html) | 0.95:1 Avatar.Fluent | [951](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Avatar.Fluent.html) | [1006](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Avatar.Fluent_base.html) | 0.95:1 Dialog.Fluent | [1587](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dialog.Fluent.html) | [1679](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dialog.Fluent_base.html) | 0.95:1 ButtonSlotsPerf.default | [568](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonSlotsPerf.default.html) | [607](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonSlotsPerf.default_base.html) | 0.94:1 LoaderMinimalPerf.default | [2315](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/LoaderMinimalPerf.default.html) | [2459](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/LoaderMinimalPerf.default_base.html) | 0.94:1 TooltipMinimalPerf.default | [827](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/TooltipMinimalPerf.default.html) | [879](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/TooltipMinimalPerf.default_base.html) | 0.94:1 AttachmentMinimalPerf.default | [906](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentMinimalPerf.default.html) | [976](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentMinimalPerf.default_base.html) | 0.93:1 MenuButtonMinimalPerf.default | [1500](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuButtonMinimalPerf.default.html) | [1608](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuButtonMinimalPerf.default_base.html) | 0.93:1 DividerMinimalPerf.default | [865](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/DividerMinimalPerf.default.html) | [940](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/DividerMinimalPerf.default_base.html) | 0.92:1 IconMinimalPerf.default | [298](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/IconMinimalPerf.default.html) | [326](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/IconMinimalPerf.default_base.html) | 0.91:1 Slider.Fluent | [1369](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Slider.Fluent.html) | [1506](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Slider.Fluent_base.html) | 0.91:1 HierarchicalTreeMinimalPerf.default | [818](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/HierarchicalTreeMinimalPerf.default.html) | [931](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/HierarchicalTreeMinimalPerf.default_base.html) | 0.88:1 LayoutMinimalPerf.default | [488](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/LayoutMinimalPerf.default.html) | [562](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/LayoutMinimalPerf.default_base.html) | 0.87:1 StatusMinimalPerf.default | [225](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/StatusMinimalPerf.default.html) | [259](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/StatusMinimalPerf.default_base.html) | 0.87:1 GridMinimalPerf.default | [865](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/GridMinimalPerf.default.html) | [1025](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/GridMinimalPerf.default_base.html) | 0.84:1 Image.Fluent | [232](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Image.Fluent.html) | [279](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/Image.Fluent_base.html) | 0.83:1 FlexMinimalPerf.default | [357](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/FlexMinimalPerf.default.html) | [440](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/FlexMinimalPerf.default_base.html) | 0.81:1 RefMinimalPerf.default | [144](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/RefMinimalPerf.default.html) | [180](https://23016-141743704-gh.circle-artifacts.com/0/artifacts/perf/RefMinimalPerf.default_base.html) | 0.8:1

Generated by :no_entry_sign: dangerJS