search

microsoft / fluent-ui-react

An ecosystem for building highly customizable enterprise class user interfaces.
https://aka.ms/fluent-ui
MIT License
432 stars 55 forks source link

Hide Safari default input outline #2381

Open sheff146 opened 4 years ago

sheff146 commented 4 years ago

Fixes issue #2376 where ugly default outline appeared on focused input in Safari. Before: safari After:

Screenshot 2020-02-21 at 16 44 52
DustyTheBot commented 4 years ago
Warnings
:warning: There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.44 0.39 1.13:1 2000 878
🦄 Button.Fluent 0.1 0.18 0.56:1 1000 103
🔧 Checkbox.Fluent 0.73 0.3 2.43:1 1000 727
🔧 Dialog.Fluent 0.3 0.16 1.88:1 5000 1491
🔧 Dropdown.Fluent 3.06 0.38 8.05:1 1000 3055
🔧 Icon.Fluent 0.12 0.03 4:1 5000 600
🦄 Image.Fluent 0.05 0.08 0.63:1 5000 231
🔧 Slider.Fluent 1.35 0.29 4.66:1 1000 1347
🔧 Text.Fluent 0.05 0.02 2.5:1 5000 259
🦄 Tooltip.Fluent 0.11 18.15 0.01:1 5000 555

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions Scenario | Current PR Ticks | Baseline Ticks | Ratio :--- | ---:| ---:| ---: FormMinimalPerf.default | [910](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/FormMinimalPerf.default.html) | [683](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/FormMinimalPerf.default_base.html) | 1.33:1 FlexMinimalPerf.default | [503](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/FlexMinimalPerf.default.html) | [396](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/FlexMinimalPerf.default_base.html) | 1.27:1 Tooltip.Fluent | [555](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Tooltip.Fluent.html) | [450](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Tooltip.Fluent_base.html) | 1.23:1 ChatMinimalPerf.default | [486](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatMinimalPerf.default.html) | [409](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatMinimalPerf.default_base.html) | 1.19:1 AnimationMinimalPerf.default | [535](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/AnimationMinimalPerf.default.html) | [459](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/AnimationMinimalPerf.default_base.html) | 1.17:1 ProviderMinimalPerf.default | [680](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMinimalPerf.default.html) | [587](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMinimalPerf.default_base.html) | 1.16:1 LabelMinimalPerf.default | [892](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/LabelMinimalPerf.default.html) | [790](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/LabelMinimalPerf.default_base.html) | 1.13:1 ReactionMinimalPerf.default | [2592](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ReactionMinimalPerf.default.html) | [2344](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ReactionMinimalPerf.default_base.html) | 1.11:1 StatusMinimalPerf.default | [249](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/StatusMinimalPerf.default.html) | [225](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/StatusMinimalPerf.default_base.html) | 1.11:1 ListMinimalPerf.default | [322](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListMinimalPerf.default.html) | [294](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListMinimalPerf.default_base.html) | 1.1:1 ButtonSlotsPerf.default | [608](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonSlotsPerf.default.html) | [561](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonSlotsPerf.default_base.html) | 1.08:1 SplitButtonMinimalPerf.default | [12369](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/SplitButtonMinimalPerf.default.html) | [11500](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/SplitButtonMinimalPerf.default_base.html) | 1.08:1 Image.Fluent | [231](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Image.Fluent.html) | [214](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Image.Fluent_base.html) | 1.08:1 AvatarMinimalPerf.default | [504](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/AvatarMinimalPerf.default.html) | [471](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/AvatarMinimalPerf.default_base.html) | 1.07:1 HeaderMinimalPerf.default | [455](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderMinimalPerf.default.html) | [426](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderMinimalPerf.default_base.html) | 1.07:1 GridMinimalPerf.default | [853](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/GridMinimalPerf.default.html) | [803](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/GridMinimalPerf.default_base.html) | 1.06:1 PopupMinimalPerf.default | [353](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/PopupMinimalPerf.default.html) | [333](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/PopupMinimalPerf.default_base.html) | 1.06:1 PortalMinimalPerf.default | [232](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/PortalMinimalPerf.default.html) | [219](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/PortalMinimalPerf.default_base.html) | 1.06:1 SliderMinimalPerf.default | [1392](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/SliderMinimalPerf.default.html) | [1312](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/SliderMinimalPerf.default_base.html) | 1.06:1 HierarchicalTreeMinimalPerf.default | [797](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/HierarchicalTreeMinimalPerf.default.html) | [757](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/HierarchicalTreeMinimalPerf.default_base.html) | 1.05:1 ListCommonPerf.default | [920](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListCommonPerf.default.html) | [877](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListCommonPerf.default_base.html) | 1.05:1 TableMinimalPerf.default | [561](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/TableMinimalPerf.default.html) | [535](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/TableMinimalPerf.default_base.html) | 1.05:1 Icon.Fluent | [600](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Icon.Fluent.html) | [569](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Icon.Fluent_base.html) | 1.05:1 HeaderSlotsPerf.default | [1262](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderSlotsPerf.default.html) | [1212](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderSlotsPerf.default_base.html) | 1.04:1 TreeWith60ListItems.default | [220](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/TreeWith60ListItems.default.html) | [212](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/TreeWith60ListItems.default_base.html) | 1.04:1 EmbedMinimalPerf.default | [5909](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/EmbedMinimalPerf.default.html) | [5747](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/EmbedMinimalPerf.default_base.html) | 1.03:1 Slider.Fluent | [1347](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Slider.Fluent.html) | [1312](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Slider.Fluent_base.html) | 1.03:1 Text.Fluent | [259](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Text.Fluent.html) | [252](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Text.Fluent_base.html) | 1.03:1 DialogMinimalPerf.default | [1561](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/DialogMinimalPerf.default.html) | [1527](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/DialogMinimalPerf.default_base.html) | 1.02:1 InputMinimalPerf.default | [913](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/InputMinimalPerf.default.html) | [897](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/InputMinimalPerf.default_base.html) | 1.02:1 MenuButtonMinimalPerf.default | [1456](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuButtonMinimalPerf.default.html) | [1423](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuButtonMinimalPerf.default_base.html) | 1.02:1 TooltipMinimalPerf.default | [688](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/TooltipMinimalPerf.default.html) | [674](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/TooltipMinimalPerf.default_base.html) | 1.02:1 ImageMinimalPerf.default | [234](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ImageMinimalPerf.default.html) | [232](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ImageMinimalPerf.default_base.html) | 1.01:1 ListWith60ListItems.default | [152](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListWith60ListItems.default.html) | [151](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListWith60ListItems.default_base.html) | 1.01:1 SegmentMinimalPerf.default | [1141](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/SegmentMinimalPerf.default.html) | [1126](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/SegmentMinimalPerf.default_base.html) | 1.01:1 DividerMinimalPerf.default | [847](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/DividerMinimalPerf.default.html) | [846](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/DividerMinimalPerf.default_base.html) | 1:1 ItemLayoutMinimalPerf.default | [1654](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ItemLayoutMinimalPerf.default.html) | [1652](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ItemLayoutMinimalPerf.default_base.html) | 1:1 MenuMinimalPerf.default | [1861](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuMinimalPerf.default.html) | [1857](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuMinimalPerf.default_base.html) | 1:1 CustomToolbarPrototype.default | [3358](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/CustomToolbarPrototype.default.html) | [3359](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/CustomToolbarPrototype.default_base.html) | 1:1 ToolbarMinimalPerf.default | [786](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ToolbarMinimalPerf.default.html) | [783](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ToolbarMinimalPerf.default_base.html) | 1:1 AttachmentMinimalPerf.default | [821](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentMinimalPerf.default.html) | [827](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentMinimalPerf.default_base.html) | 0.99:1 AttachmentSlotsPerf.default | [3020](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentSlotsPerf.default.html) | [3044](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentSlotsPerf.default_base.html) | 0.99:1 TextAreaMinimalPerf.default | [2831](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextAreaMinimalPerf.default.html) | [2859](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextAreaMinimalPerf.default_base.html) | 0.99:1 Checkbox.Fluent | [727](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Checkbox.Fluent.html) | [736](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Checkbox.Fluent_base.html) | 0.99:1 Dialog.Fluent | [1491](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dialog.Fluent.html) | [1504](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dialog.Fluent_base.html) | 0.99:1 ChatWithPopoverPerf.default | [509](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatWithPopoverPerf.default.html) | [520](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatWithPopoverPerf.default_base.html) | 0.98:1 CheckboxMinimalPerf.default | [3454](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/CheckboxMinimalPerf.default.html) | [3518](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/CheckboxMinimalPerf.default_base.html) | 0.98:1 RefMinimalPerf.default | [149](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/RefMinimalPerf.default.html) | [152](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/RefMinimalPerf.default_base.html) | 0.98:1 TextMinimalPerf.default | [264](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextMinimalPerf.default.html) | [270](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextMinimalPerf.default_base.html) | 0.98:1 TreeMinimalPerf.default | [813](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/TreeMinimalPerf.default.html) | [831](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/TreeMinimalPerf.default_base.html) | 0.98:1 VideoMinimalPerf.default | [655](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/VideoMinimalPerf.default.html) | [666](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/VideoMinimalPerf.default_base.html) | 0.98:1 Avatar.Fluent | [878](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Avatar.Fluent.html) | [896](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Avatar.Fluent_base.html) | 0.98:1 BoxMinimalPerf.default | [233](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/BoxMinimalPerf.default.html) | [239](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/BoxMinimalPerf.default_base.html) | 0.97:1 DropdownMinimalPerf.default | [3258](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownMinimalPerf.default.html) | [3349](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownMinimalPerf.default_base.html) | 0.97:1 IconMinimalPerf.default | [292](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/IconMinimalPerf.default.html) | [300](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/IconMinimalPerf.default_base.html) | 0.97:1 LoaderMinimalPerf.default | [763](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/LoaderMinimalPerf.default.html) | [786](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/LoaderMinimalPerf.default_base.html) | 0.97:1 AccordionMinimalPerf.default | [209](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/AccordionMinimalPerf.default.html) | [217](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/AccordionMinimalPerf.default_base.html) | 0.96:1 ChatDuplicateMessagesPerf.default | [371](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatDuplicateMessagesPerf.default.html) | [387](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatDuplicateMessagesPerf.default_base.html) | 0.96:1 LayoutMinimalPerf.default | [604](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/LayoutMinimalPerf.default.html) | [628](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/LayoutMinimalPerf.default_base.html) | 0.96:1 ProviderMergeThemesPerf.default | [1072](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMergeThemesPerf.default.html) | [1118](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMergeThemesPerf.default_base.html) | 0.96:1 Dropdown.Fluent | [3055](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dropdown.Fluent.html) | [3178](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dropdown.Fluent_base.html) | 0.96:1 ListNestedPerf.default | [645](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListNestedPerf.default.html) | [687](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListNestedPerf.default_base.html) | 0.94:1 DropdownManyItemsPerf.default | [412](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownManyItemsPerf.default.html) | [442](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownManyItemsPerf.default_base.html) | 0.93:1 RadioGroupMinimalPerf.default | [407](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/RadioGroupMinimalPerf.default.html) | [438](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/RadioGroupMinimalPerf.default_base.html) | 0.93:1 ButtonMinimalPerf.default | [119](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonMinimalPerf.default.html) | [130](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonMinimalPerf.default_base.html) | 0.92:1 CarouselMinimalPerf.default | [1815](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/CarouselMinimalPerf.default.html) | [1993](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/CarouselMinimalPerf.default_base.html) | 0.91:1 Button.Fluent | [103](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Button.Fluent.html) | [113](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/Button.Fluent_base.html) | 0.91:1 AlertMinimalPerf.default | [625](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/AlertMinimalPerf.default.html) | [700](https://23219-141743704-gh.circle-artifacts.com/0/artifacts/perf/AlertMinimalPerf.default_base.html) | 0.89:1

Generated by :no_entry_sign: dangerJS