search

microsoft / fluentui-contrib

Monorepo for contributor extension packages to Fluent UI
MIT License
31 stars 35 forks source link

feat(react-tree-grid): adds virtualization support #96

Closed bsunderhus closed 9 months ago

bsunderhus commented 9 months ago
  1. deletes TreeGridRowGroup component in favor of subtree slot
    • The component is problematic for the virtualization scenario (as for virtualization libraries the rendering should be flattened, with all components in the same level and with TreeGridRowGroup this is not possible)
    • Some problems with this implementation were pointed here https://github.com/microsoft/fluentui-contrib/pull/85
    • subtree slot (although not an ideal syntax) is predictable and simpler to use
  2. adds virtualization story (similar to FlatTree virtualization)
  3. updates default story to use subtree slot
  4. adds react-window as devDependency
  5. starts using slot API

TODO

  1. The Virtualization example is quite complex, needs simplification
  2. create @fluentui-contrib/react-tree-grid-react-window?!