search

microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.34k stars 2.72k forks source link

Dropdown Check box checked icon is not visible in High contrast black/white mode. #16161

Closed nadavWeisler closed 2 years ago

nadavWeisler commented 3 years ago

Environment Information

Describe the issue:

Check box checked icon is not visible in High contrast black/white mode

Please provide a reproduction of the issue in a codepen:

https://codepen.io/nadavWeisler/pen/BaLzoBZ

Actual behavior:

Check box checked icon is not visible in High contrast black/white mode

Expected behavior:

Check box checked icon should be visible in High contrast black/white mode

Documentation describing expected behavior

https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc=%7b672c8a8b-ed4f-463f-868f-e8131caf9b74%7d

paulgildea commented 3 years ago

@nadavWeisler Thanks for filing this issue.

@ecraig12345 Can you determine if this repros with the current version of the library and root cause?

@xugao FYI

dawolff-ms commented 3 years ago

@paulgildea @ecraig12345 has there been any progress on this? Our team has a blocking MAS bug for this issue.

Does anyone know of any workarounds?

smhigley commented 3 years ago

I actually can't reproduce the issue, I can see the checks OK (unless I'm missing something): screenshot of open multiselect dropdown, showing both checked and unchecked options

ecraig12345 commented 3 years ago

@dawolff-ms Which Fabric/Fluent version and Edge version are you seeing the issue in?

dawolff-ms commented 3 years ago

@ecraig12345 @smhigley

Microsoft Windows 10 Enterprise Version 20H2 (OS build: 19042.804) Chromium Edge Version 90.0.803.0 (Official build) dev (64-bit) fluentui/react: 7.147.1

In the words of the MAS tester who logged this bug: (when all options are selected) "user is not able to identify [check marks] as check boxes, so the check box outline should be visible to the user. And also, keyboard focus should be clearly visible".

dawolff-ms commented 3 years ago

@smhigley if the checkmark looks good to you, then that's great. But, there is still an issue related to #12121 where in high contrast if all items are selected it becomes very difficult for the user to determine where keyboard focus is.

Do you think it's worth logging a separate issue for high contrast? Can this issue be closed if you don't see an issue with the checkmark?

msft-fluent-ui-bot commented 2 years ago

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.