Enable @fluentui/react-storybook-addon in react-components

microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.

https://react.fluentui.dev

Other

18.51k stars 2.73k forks source link

Enable @fluentui/react-storybook-addon in react-components #20896

Closed layershifter closed 2 years ago

layershifter commented 2 years ago

We should find a way to enable the addon again without breaking buildless experience (#20886).

Hotell commented 2 years ago

I cannot repro the issue with addon itself - as you described, the only issue is with not having babel-make-styles plugin build. Addon buildless experience works as expected.

no build artifacts present ( dependencies of addon package )
build artifact present ( babel-make-styles )
executing storybook on react-components works. also theming works again

layershifter commented 2 years ago

@Hotell it happens with Storybook manager, run it without cache:

Enable addon in packages/react-components/.storybook/main.js
yarn workspace @fluentui/react-provider clean
yarn workspace @fluentui/react-theme clean
yarn workspace @fluentui/react-components start --no-manager-cache

Hotell commented 2 years ago

hmm I was able to repro it when running in docs mode:

yarn workspace @fluentui/react-components storybook:docs

2022-01-11 at 10 34

Update: right, turning off manager cache exposes the issue for standard start-storybook as well.

thx!

Hotell commented 2 years ago

our custom addon is enabled without buildless experience atm, thus I'm keeping this issue open

msft-fluent-ui-bot commented 2 years ago

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

Hotell commented 2 years ago

fixed by https://github.com/microsoft/fluentui/pull/24168