microsoft / ga4gh-tes

C# implementation of the GA4GH TES API; provides distributed batch task execution on Microsoft Azure
MIT License
34 stars 27 forks source link

Fix default CL args #223

Open ashanhol opened 1 year ago

ashanhol commented 1 year ago

Problem: Right now the default string we provide users is --subscriptionid aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee --regionname westus2 --mainidentifierprefix coatest in launchSettings.json

Solution: It needs to be (per the wiki) deploy-tes-on-azure-win.exe --subscriptionid aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee --regionname southcentralus --mainidentifierprefix example --helmbinarypath C:\ProgramData\chocolatey\bin\helm.exe --enableingress true --letsencryptemail example@example.com

MattMcL4475 commented 11 months ago

@ngambani can you please ensure the documentation is updated for this? I can update the code part of this.

ngambani commented 11 months ago

@MattMcL4475 can you clarify where do we need a documentation update? I checked the wiki is up to date, is there anywhere else that I should be making this update?