search

microsoft / git

A fork of Git containing Microsoft-specific patches.
http://git-scm.com/
Other
761 stars 92 forks source link

release: fix federated auth #669

Closed dscho closed 2 months ago

dscho commented 2 months ago

One "funny" quirk of GitHub Actions is that some of their YAML constructs that users assume to be cumulative, are not. One example is the permissions block: Most readers will assume that the following YAML will combine contents and id-token permissions:

permissions:
  id-token: write

jobs:
  my-job:
    permissions:
      contents: write

However, that is not the case! The inner permissions block completely negates the outer permissions block. This can be seen in all its glory here. With this commit, the bug is fixed.