search

microsoft / hi-ml

HI-ML toolbox for deep learning for medical imaging and Azure integration
https://aka.ms/hi-ml
MIT License
269 stars 60 forks source link

BUG: Hyperdrive jobs not possible with v2 SDK #880

Open ant0nsc opened 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #880 (6d36fa7) into main (7e8c8a0) will increase coverage by 0.02%. The diff coverage is 75.38%.

Impacted file tree graph

Flag Coverage Δ
hi-ml 82.89% <76.56%> (-0.13%) :arrow_down:
hi-ml-azure 25.37% <0.00%> (-0.02%) :arrow_down:
hi-ml-cpath 75.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hi-ml-azure/src/health_azure/himl.py 26.93% <0.00%> (-0.09%) :arrow_down:
hi-ml/src/health_ml/experiment_config.py 100.00% <ø> (ø)
hi-ml/src/health_ml/configs/hello_world.py 83.45% <41.66%> (-3.95%) :arrow_down:
hi-ml/src/health_ml/utils/common_utils.py 84.89% <83.33%> (-0.98%) :arrow_down:
hi-ml/src/health_ml/deep_learning_config.py 84.58% <100.00%> (+0.06%) :arrow_up:
hi-ml/src/health_ml/runner.py 87.64% <100.00%> (+0.75%) :arrow_up:
fepegar commented 6 months ago

In case it helps, this has been driving me a bit crazy today as well. I've found from older runs of mine that the shared memory is correctly taken into account when downgrading to azure-ai-ml==1.5.0. I was trying 1.15.0 so I think that feature was broken somewhere in between.

fepegar commented 6 months ago

In case it helps, this has been driving me a bit crazy today as well. I've found from older runs of mine that the shared memory is correctly taken into account when downgrading to azure-ai-ml==1.5.0. I was trying 1.15.0 so I think that feature was broken somewhere in between.

I've run some tests. This is broken for azure-ai-ml>=1.13.0.