search

microsoft / mssql-jdbc

The Microsoft JDBC Driver for SQL Server is a Type 4 JDBC driver that provides database connectivity with SQL Server through the standard JDBC application program interfaces (APIs).
MIT License
1.06k stars 427 forks source link

fix issue-2530 encrypted private keys is not working issue #2532

Open muskaan62 opened 4 weeks ago

muskaan62 commented 4 weeks ago

client certificate without password (the test you provide for this scenario) [working] client certificate with password [working] client certificate with private key [working] client certificate with private key and key password (i.e means encrypted key) [bug] The above 3 ways are working fine but fourth is not .. The logic for decrypt the private key is restricted to pvk though providing pvk key also its not working types and RSA private keys when decrypting also failing so added a fix for this. related to https://github.com/microsoft/mssql-jdbc/issues/2530

muskaan62 commented 4 weeks ago

@lilgreenbird FYI

lilgreenbird commented 3 weeks ago

thanks the team will take a look

muskaan62 commented 3 weeks ago

Thanks @lilgreenbird @Jeffery-Wasty can we expect this fix in 12.8.1 version or it will be available with new version of driver?

lilgreenbird commented 2 weeks ago

@muskaan62 please see above you will need to agree to CLA before the PR can be considered and tests run on it

muskaan62 commented 4 days ago

@microsoft-github-policy-service agree company="Gaian Solutions"

muskaan62 commented 4 days ago

@muskaan62 please see above you will need to agree to CLA before the PR can be considered and tests run on it

@lilgreenbird Done, lemme know anything else to be done from my end.