search

microsoft / mssql-jdbc

The Microsoft JDBC Driver for SQL Server is a Type 4 JDBC driver that provides database connectivity with SQL Server through the standard JDBC application program interfaces (APIs).
MIT License
1.06k stars 427 forks source link

Feature-32573 When using AccessTokenCallback, remove validation that requires Password to be empty. #2544

Closed Ananya2 closed 1 day ago

Ananya2 commented 1 week ago

SQLServerConnection connectInternal() throws exception R_AccessTokenCallbackWithUserPassword. This logic may be too restrictive and may be removed. https://sqlclientdrivers.visualstudio.com/mssql-jdbc/_workitems/edit/32573

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.23%. Comparing base (5297987) to head (5c4f0f4). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2544 +/- ## ============================================ + Coverage 51.10% 51.23% +0.12% - Complexity 3935 3972 +37 ============================================ Files 147 147 Lines 33460 33666 +206 Branches 5608 5655 +47 ============================================ + Hits 17101 17248 +147 - Misses 13971 14005 +34 - Partials 2388 2413 +25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Ananya2 commented 1 day ago

Changes have already been requested as a part of https://github.com/microsoft/mssql-jdbc/pull/2549 , hence closing the PR.