Possible reversed functions in winml compute shaders

microsoft / onnxruntime

ONNX Runtime: cross-platform, high performance ML inferencing and training accelerator

https://onnxruntime.ai

MIT License

14.61k stars 2.92k forks source link

Possible reversed functions in winml compute shaders #5964

Open ashikns opened 3 years ago

ashikns commented 3 years ago

Describe the bug I was looking through the source of winml parts and noticed that in this shader SurfaceToTensorFloat.hlsl the definitions of SurfaceToTensorGRAY8and SurfaceToTensorRGB8looks like they're reversed/swapped? GRAY8 version assigns 3 values per output and RGB8 assigns only one. Apologies in advance if I've missed something here and it's actually correct.

Urgency None. I will not ultimately be using built-in tensorization.

hariharans29 commented 3 years ago

CC: @fdwr @wchao1115

fdwr commented 3 years ago

🤨 Indeed, these appear swapped. Asking the person who wrote it...

fdwr commented 3 years ago

Assigned to @zhangxiang1993 (internal bug 31346263).

stale[bot] commented 2 years ago

This issue has been automatically marked as stale due to inactivity and will be closed in 7 days if no further activity occurs. If further support is needed, please provide an update and/or more details.

fdwr commented 2 years ago

@zhangxiang1993 Any updates?