Add new bridge call to update runc container

microsoft / opengcs

Moved to https://github.com/microsoft/hcsshim/tree/master/internal/guest. If you wish to open PRs/submit issues please do so against https://github.com/microsoft/hcsshim.

MIT License

83 stars 41 forks source link

Add new bridge call to update runc container #380

Closed katiewasnothere closed 4 years ago

katiewasnothere commented 4 years ago

This PR allows for LCOW container updates as part of the work to allow for dynamic resource changes during container runtime

Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com

kevpar commented 4 years ago

Two thoughts on this, but I don't have time to look into them further this week:

Should we re-use the existing modify settings bridge message?
Should we define a message struct that has something like WindowsResources and LinuxResources members, so we can have some stronger typing, but also use this for Windows in the future (without diverging the bridge protocol).

kevpar commented 4 years ago

I don't think those items necessarily need to block, but would be good to have some understanding of them.

katiewasnothere commented 4 years ago

Two thoughts on this, but I don't have time to look into them further this week:

Should we re-use the existing modify settings bridge message?

Should we define a message struct that has something like WindowsResources and LinuxResources members, so we can have some stronger typing, but also use this for Windows in the future (without diverging the bridge protocol).

I'm going to merge this for now but spend some time this week looking into your comments and make any additional PRs for that.