search

microsoft / opengcs

Moved to https://github.com/microsoft/hcsshim/tree/master/internal/guest. If you wish to open PRs/submit issues please do so against https://github.com/microsoft/hcsshim.
MIT License
83 stars 41 forks source link

Revert previous change that issues a kill all on container stop for LCOW #382

Closed katiewasnothere closed 4 years ago

katiewasnothere commented 4 years ago

Reverts https://github.com/microsoft/opengcs/pull/329 to better match the behavior of other shims and reflect the users request more accurately. This avoids an issue where child processes are killed before getting the chance to be cleaned up gracefully.

Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com

katiewasnothere commented 4 years ago

Verified by running the full cri-containerd test suite and double checking success with https://github.com/microsoft/hcsshim/pull/778.

katiewasnothere commented 4 years ago

@microsoft/containerplat PTAL :)