microsoft / opengcs

Moved to https://github.com/microsoft/hcsshim/tree/master/internal/guest. If you wish to open PRs/submit issues please do so against https://github.com/microsoft/hcsshim.
MIT License
83 stars 41 forks source link

Add a new generic hook for use in device setup #388

Closed katiewasnothere closed 3 years ago

katiewasnothere commented 3 years ago

This PR removes the nvidiaPrestartHook binary for assigning nvidia devices into containers in favor of genericHook. genericHook can take an arbitrary binary and arguments to execute as an oci-hook (can be any type of hook). genericHook has the ability to fill in templated options in the arguments given, which allows for filling in values that are not known until runtime of the hook.

This PR additionally adds a function to setup an oci prestart hook to run ldconfig, which is needed particularly for device assignment to ensure drivers are loaded.

Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com