search

microsoft / opengcs

Moved to https://github.com/microsoft/hcsshim/tree/master/internal/guest. If you wish to open PRs/submit issues please do so against https://github.com/microsoft/hcsshim.
MIT License
83 stars 41 forks source link

Change the update container bridge call to use the modify call instead #391

Closed katiewasnothere closed 3 years ago

katiewasnothere commented 3 years ago

This PR updates OpenGCS to reuse the modify bridge call when issuing a request to update a container. Since the modify call was previously only used if the requested containerID is that of the UVM's pause container (null container ID), this PR additionally updates the code path to allow requests with specific container ID's to issue update calls but prevents them from issuing any host specific settings changes (such as adding a new mapped device in or a VPCI device).

Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com

katiewasnothere commented 3 years ago

@kevpar FYI :)

katiewasnothere commented 3 years ago

@dcantah and/or @anmaxvl would you PTAL when you get the chance? :) Rebased to account for the recent V1 removal