Remove netnscfg gcstools utility - Githubissues

microsoft / opengcs

Moved to https://github.com/microsoft/hcsshim/tree/master/internal/guest. If you wish to open PRs/submit issues please do so against https://github.com/microsoft/hcsshim.

MIT License

83 stars 41 forks source link

Remove netnscfg gcstools utility #393

Closed dcantah closed 3 years ago

dcantah commented 3 years ago

This utility only existed because go used to not play well with network namespaces due to it's nature of goroutine thread multiplexing. This poor behavior was remedied/solved in go 1.10 due to some changes in how runtime.LockOSThread works with regards to scheduling new goroutines and spawning new threads.

Great article on the problem: https://www.weave.works/blog/linux-namespaces-and-go-don-t-mix

and the eventual resolution: https://www.weave.works/blog/linux-namespaces-golang-followup

Add DoInNetNS function to perform a function in a specific network namespace.
Convert netnscfg to a function to be used in tandem with DoInNetNS

Signed-off-by: Daniel Canter dcanter@microsoft.com

dcantah commented 3 years ago

@katiewasnothere Remedied things, ptal