Feature flag needed for the org write feature

microsoft / opensource-management-portal

Microsoft's monolithic, opinionated Open Source Management Portal enabling enterprise scale self-service powered by the GitHub API 🏔🧑‍💻🧰

https://jeffwilcox.blog/2019/06/scaling-25k/

MIT License

490 stars 124 forks source link

Feature flag needed for the org write feature #391

Open jeffwilcox opened 1 year ago

jeffwilcox commented 1 year ago

We've stopped using the org accept invite endpoint of a user's token after hitting a lot of interesting edge cases.

In our latest source, we have a constant shouldAttemptAcceptingInvitations = false value in the code that should probably become a feature flag, or, a call whether to keep it or not.

What's nice when it works:

Single click join
Things just work for the user

What's not nice:

Issues with SAML SSO at times
Blocked invites issue from GitHub API at times

github-actions[bot] commented 1 year ago

This issue has been identified as stale because it has gone 30 days with no activity. The issue will be closed in 10 days. If this is incorrect, simply comment on the issue, or remove the stale label.