microsoft / perfview

PerfView is a CPU and memory performance-analysis tool
http://channel9.msdn.com/Series/PerfView-Tutorial
MIT License
4.2k stars 712 forks source link

The GroupRegExs and FoldRegExs filters are not propagated to StackWindow when using OpenStackViewer #2098

Open ara-ayvazyan opened 3 months ago

ara-ayvazyan commented 3 months ago

The GroupRegExs and FoldRegExs filters are not propagated to StackWindow when using OpenStackViewer.

public class Commands : CommandEnvironment
{
    public void TestFileView(string fileName, string viewName)
    {
        var etlFile = OpenETLFile(fileName);
        var stacks = new Stacks(new MutableTraceEventStackSource(etlFile.TraceLog), viewName, etlFile);
        stacks.Filter.GroupRegExs += "GroupRegExs";
        stacks.Filter.FoldRegExs += "FoldRegExs";
        stacks.Filter.IncludeRegExs += "IncludeRegExs";
        stacks.Filter.ExcludeRegExs += "ExcludeRegExs";
        stacks.Filter.MinInclusiveTimePercent += "12.34";
        OpenStackViewer(stacks);
    }
}

image

I think they are applied to the data itself, but the drop downs don't show them.

Default values for the Stacks.Filter don't seem to match with those in StackWindow.

When changing the values on the dropdown, it doesn't seem to overwrite the filter values set to Stacks (e.g., when clearing the FoldPats).