[Feature]: Add Electron support

cserby commented 3 years ago

I'd like to ask if there is a chance (plan, roadmap) to have playwright-electron's functionality exposed in playwright-python as well.

We have a quite extensive e2e test framework and suite based on pytest, and recent good experiences with playwright-electron ignited some ideas about including our electron-based app in the e2e tests as well.

pavelfeldman commented 3 years ago

That's actually very easy to do, especially if you are here to tell us if that worked.

We are prepping Python API to go stable (v1.8 instead of v0.180) and this will break all the APIs to make them snake_case. Will you be able to migrate your Playwright tests to snake_case to validate how Electron is working for you?

cserby commented 3 years ago

Honestly, I'd be happy to, but we don't yet use playwright-python extensively as we're missing this functionality. We use playwright-electron in a standalone test framework, specifically targeted on our Electron-based app.

pavelfeldman commented 3 years ago

Ok, so you don't have any existing playwright-python tests, that's cool. I'm leaving it open to collect more votes, but it is relatively straightforward, so I'm up for doing it right after we publish stable Python semver. Should be a couple of weeks. But it might be that someone picks it up sooner than that. @mxschmitt fyi

MrGreenTea commented 3 years ago

@pavelfeldman What would be needed to get electron tests running with this? You said it should be very easy so perhaps you can point me in the direction to get started?

rishabh-plivo commented 3 years ago

@pavelfeldman Hey is this integrated already? Looking to get started with our Electron-based app.

cserby commented 3 years ago

Do we maybe have an ETA? We're currently at a point, where we need to decide if we go for JS or python for implementing the next test framework for our products.

mxschmitt commented 3 years ago

Hey, unfortunately this issue got not much attention in the past, we thought about it but since Electron is JavaScript in the end the experience would be also much nicer when you use the normal Playwright for JavaScript or TypeScript directly which works today. See here: https://playwright.dev/docs/api/class-electron

frederickishimwe commented 2 years ago

this would be really useful for python testers to migrate to electron app testing without needing to learn JavaScript

zerocewl commented 2 years ago

+1

Our testers are interested too in testing electron apps with python (e.g. as it can be done with selenium).

trevorwang commented 2 years ago

+1

jiangliq2000 commented 2 years ago

+1, we also want to use python to test electron app

vaffeljarnet commented 2 years ago

+1, we also need this

spursbob commented 2 years ago

+1

robertlagrant commented 2 years ago

+1

@mxschmitt are there some docs around what features each client language will likely get? We would like to use this, but wouldn't want to risk missing key features if Python is a second class language in the tool.

mxschmitt commented 2 years ago

+1

@mxschmitt are there some docs around what features each client language will likely get? We would like to use this, but wouldn't want to risk missing key features if Python is a second class language in the tool.

Electron is still in beta in Node.js that's why we didn't port it yet.

uglybug commented 2 years ago

If and when this gets done, can the pytest plugin also be aware of this? At the moment, as far as I am aware, you can only control the browser from --browser and --browser-channel command line options for pytest. For an Electron application, maybe it could look something like --browser electron --browser-channel path/to/application?

Vinyzu commented 1 year ago

+1

freetomik commented 1 year ago

+1 I would also appreciate support for electron apps. It would be great to use pytest on frontend side, since I have already some tests on backend API written in it.

brad-adr-runtime commented 1 year ago

+1 we are planning to have an electron app as well so this would be super useful. Already using playwright in python.

amielnoy commented 1 year ago

I will also want @mxschmitt to add the python support There is a big community of python playwright implementors that need this support And we at israel are expecting at lease a roadmap regarding this At leasest a roadmap to start a python beta Please! @mxschmitt @pavelfeldman