microsoft / pxt-microbit

A Blocks / JavaScript code editor for the micro:bit built on Microsoft MakeCode
https://makecode.microbit.org
Other
721 stars 593 forks source link

Screenshot button keeps spinning if you share project #5224

Closed Sheila111 closed 1 year ago

Sheila111 commented 1 year ago

Describe the bug Screenshot button keeps spinning if you share project

Steps to reproduce the behavior

  1. Navigate to https://makecode.microbit.org/beta#
  2. Create a project
  3. Click share button to enter the share dialog

Actual behavior Screenshot button keeps spinning if you share project. The issue always repro whether you share or not, once you enter the share dialog.

Expect behavior Screenshot button won't spin if you share project.

Screenshot 2

Additional context 1.OS: Windows11 2.makecode.microbit.org version: 5.1.37 3.Microsoft MakeCode version: 8.6.48

Sheila111 commented 1 year ago

The issue can restore if you refresh the page

abchatra commented 1 year ago

@kimprice resolve if fixed.

kimprice commented 1 year ago

Yea this should be fixed. I just need to bump pxt and then microbit, which I'm doing now.