search

microsoft / python-language-server

Microsoft Language Server for Python
Apache License 2.0
910 stars 130 forks source link

Add pdbs to nuget spec file #2146

Closed rchiodo closed 3 years ago

rchiodo commented 3 years ago

@jakebailey can you sign off on this? We're assuming you have write access.

We need to rev the nuget package for the parsing dll so that D17 of the python tools can use the parsing dll. Submission requirements state all dlls need a pdb

jakebailey commented 3 years ago

Hm, should this go to the ptvs branch? Not sure where ptvs gets it stuff from.

jakebailey commented 3 years ago

If master is where it's generated from, then LGTM, though I'm surprised to be modifying master at this point.

jakebailey commented 3 years ago

(Maybe we make a branch that's the support branch rather than committing to master?)

bschnurr commented 3 years ago

if it was adding new functionally I'd agree. but this is fixing an oversight.