microsoft / react-native-code-push

React Native module for CodePush
http://appcenter.ms
Other
8.99k stars 1.48k forks source link

[iOS] App Rejection 2 Feb 2023 #2434

Closed iMokhles closed 1 year ago

iMokhles commented 1 year ago

Hi all here's the rejection reason i received from apple's review team yesterrday

Guideline 2.3.1 - Performance

We discovered that your app contains hidden features.

Specifically, your app still contains CodePush-related remote code downloading/updating support in its main binary and main.jsbundle files. It would be appropriate to remove any and all remote package importing or hot updating functionality from this app, such as this app's [CodePushPackage downloadAndReplaceCurrentBundle:] method, before resubmitting for review.

The next submission of this app may require a longer review time.

Next Steps

Submitting apps designed to mislead or harm customers or evade the review process may result in the termination of your Apple Developer Program account. Review the Terms & Conditions of the Apple Developer Program to learn more about our policies regarding termination.

Guideline 2.5.2 - Performance - Software Requirements

Your app, extension, or linked framework appears to contain code designed explicitly with the capability to change your app’s behavior or functionality after App Review approval, which is not in compliance with App Store Review Guideline 2.5.2 and section 3.3.2 of the Apple Developer Program License Agreement.

This code, combined with a remote resource, can facilitate significant changes to your app’s behavior compared to when it was initially reviewed for the App Store. While you may not be using this functionality currently, it has the potential to load private frameworks, private methods, and enable future feature changes. This includes any code which passes arbitrary parameters to dynamic methods such as dlopen(), dlsym(), respondsToSelector:, performSelector:, method_exchangeImplementations(), and running remote scripts in order to change app behavior and/or call SPI, based on the contents of the downloaded script. Even if the remote resource is not intentionally malicious, it could easily be hijacked via a Man In The Middle (MiTM) attack, which can pose a serious security vulnerability to users of your app.

The next submission of this app may require a longer review time.

Next Steps

Submitting apps designed to mislead or harm customers or evade the review process may result in the termination of your Apple Developer Program account. Review the Terms & Conditions of the Apple Developer Program to learn more about our policies regarding termination.

iOS App 1.1App Version

Rejection Reasons:

2.3.1 Performance: Accurate Metadata

2.5.2 Performance: Software Requirements

Any updates or solution for this ? keep in mind they needs me to remove this ( [CodePushPackage downloadAndReplaceCurrentBundle:] method ) from the app ......

kasterlod commented 1 year ago

hello @iMokhles - quick question, how are you delivering updates? It was pushed before review of new version started or after?

ajlee4 commented 1 year ago

@iMokhles have you solved this problem?

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

iMokhles commented 1 year ago

any updates ?

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

microsoft-github-policy-service[bot] commented 1 year ago

This issue will now be closed because it hasn't had any activity for 15 days after stale. Please feel free to open a new issue if you still have a question/issue or suggestion.

microsoft-github-policy-service[bot] commented 1 year ago

This issue will now be closed because it hasn't had any activity for 15 days after stale. Please feel free to open a new issue if you still have a question/issue or suggestion.