search

microsoft / react-native-windows

A framework for building native Windows apps with React.
https://microsoft.github.io/react-native-windows/
Other
16.37k stars 1.14k forks source link

Unfork NetworkIOAgent files and Utf8.h #13587

Open TatianaKapos opened 3 months ago

TatianaKapos commented 3 months ago

Problem Description

Integration added these files which have multiple issues with types and annoyonous namespace. Currently have a fix in an override file but need verification that it was handled correctly before making a PR upstream.

image

Link to the integration where the error originated

https://github.com/microsoft/react-native-windows/pull/13554

Link to commit

https://github.com/facebook/react-native/pull/45426 https://github.com/facebook/react-native/pull/45445 https://github.com/facebook/react-native/commit/193cdc36f7de5524b509e38da8feb209d214634c

Forked files

  1. vnext\ReactCommon\TEMP_UntilReactCommonUpdate\jsinspector-modern\NetworkIOAgent.cpp
  2. vnext\ReactCommon\TEMP_UntilReactCommonUpdate\jsinspector-modern\NetworkIOAgent.h
  3. vnext\ReactCommon\TEMP_UntilReactCommonUpdate\jsinspector-modern\Utf8.h

Upstream PR

N/A

Build Configuration

Debug

jonthysell commented 2 months ago

@vmoroz @JunielKatarn This looks like JSI and networking, either of you care to look at this?