search

microsoft / referencesource

Source from the Microsoft .NET Reference Source that represent a subset of the .NET Framework
https://referencesource.microsoft.com/
MIT License
3.16k stars 1.27k forks source link

Reference Source repo: Resource string files missing #102

Open karelz opened 5 years ago

karelz commented 5 years ago

From @xt0rted on Saturday, 30 April 2016 15:06:59

The resource file /src/System.ComponentModel.Annotations/src/Resources/Strings.resx is not part of Microsoft/referencesource which mono is using. As a result validation results on mono have the resource names being returned instead of the actual validation message. Running the same code on Windows returns proper validation messages.

Copied from original issue: dotnet/corefx#8201

karelz commented 5 years ago

From @ellismg on Sunday, 01 May 2016 00:05:57

/cc @richlander @terrajobst

karelz commented 5 years ago

From @divega on Friday, 10 February 2017 21:23:59

@karelz not sure the area-System.ComponentModel.DataAnnotations label is appropriate for this issue. Do you know who could actually help with getting the resx files into the reference source repo?

karelz commented 5 years ago

From @karelz on Friday, 10 February 2017 21:46:21

Xamarin is now migrating to use CoreFX (sources now, binaries hopefully later). @marek-safar, is it interesting/valuable for Xamarin to have the reference source fixed? Or would you rather close it and wait for the CoreFX consumption?

karelz commented 5 years ago

From @marek-safar on Saturday, 11 February 2017 14:38:45

I looked at System.ComponentModel.DataAnnotations few days ago and it looks like we won't be able to use it for some time as it's missing quite few APIs and implementation dependencies in CoreFX compare to full .NET hence even though we'd love to use it we need to first put back code which was removed in CoreFX.

I'll try to use at least CoreFX resx files instead of referencesource to resolve this issue.

karelz commented 5 years ago

From @karelz on Saturday, 11 February 2017 18:20:49

@richlander @terrajobst what is the process for updating one file in https://github.com/Microsoft/referencesource? If it is cheap, it might be easier to do that instead of asing @marek-safar to mix and match bits from various sources and then chase down differences later :(

karelz commented 5 years ago

From @divega on Monday, 13 February 2017 22:51:57

@karelz it looks like this should probably be assigned to someone outside of our team to come to resolution. Will you figure out the right owner?

karelz commented 5 years ago

From @karelz on Monday, 13 February 2017 23:29:06

@divega when we know who should do the work, I agree - right now we need to get traction on what needs to happen where, so keeping it in the feature area seems most logical (e.g. we might need your team to "approve" releasing the source code). Makes sense?

karelz commented 5 years ago

From @richlander on Wednesday, 08 March 2017 05:01:01

@preetikr

karelz commented 5 years ago

From @lajones on Tuesday, 18 April 2017 22:56:09

Ping... @karelz @richlander @preetikr We are fine with releasing the resources. But we don't know who copies it into Microsoft/referencesource.

karelz commented 5 years ago

From @richlander on Wednesday, 19 April 2017 05:28:41

Awesome. Will pass on ...

karelz commented 5 years ago

From @divega on Wednesday, 19 April 2017 21:00:05

Clearing up milestone so that we can track this for now in our triage.

karelz commented 5 years ago

From @ajcvickers on Friday, 22 February 2019 23:45:18

Removing this from data-annotations area because there is currently nothing actionable by the area owners. We would be happy to do the work here, but without clear guidance from people who know about these things there is nothing we can currently do. Also happy to close if the value is not high enough to get such guidance.

karelz commented 5 years ago

From @karelz on Friday, 29 March 2019 02:07:38

@ajcvickers please always set new area label. Issues without area labels are not tracked and won't get any attention.