microsoft / security-devops-action

Microsoft Security DevOps for GitHub Actions.
MIT License
104 stars 47 forks source link

TemplateAnalyzer: Error parsing Bicep when a parameter isn't specified #65

Open pamelafox opened 1 year ago

pamelafox commented 1 year ago

We have a situation where we use azd to deploy Bicep files, and we intentionally leave one of the parameters unspecified, so that azd prompts for that parameter.

However, the template-analyzer errors out in that case: https://github.com/Azure-Samples/azure-search-openai-demo/actions/runs/5612367638/job/15205930925

    Directory: /home/runner/work/azure-search-openai-demo/azure-search-openai-demo
    Error: An exception occurred while analyzing template /home/runner/work/azure-search-openai-demo/azure-search-openai-demo/infra/main.bicep with parameters file /home/runner/work/azure-search-openai-demo/azure-search-openai-demo/infra/main.parameters.json
    Exception details:
    Microsoft.Azure.Templates.Analyzer.Core.TemplateAnalyzerException: Error while processing template.
     ---> Azure.Deployments.Templates.Exceptions.TemplateValidationException: The value for the template parameter 'openAiResourceGroupLocation' at line '83' and column '36' is not provided. Please see https://aka.ms/arm-create-parameter-file for usage details.

I tried providing test.parameters.json with it filled in, but that doesn't work due to issue #47

It'd be great if either #47 was fixed or if it didn't error with an unprovided parameter.

aakanshaverma1310 commented 1 year ago

@pamelafox - Hi, are you using azure devops pipeline task "MicrosoftSecurityDevOps@1" ? If yes then I have a query- How are you passing GDN_TEMPLATEANALYZER_ANALYZEDIRECTORY environment variable for scanning bicep template.

in my case I have a folder which has the bicep template.

I have tried below, but thats not working and scanning the complete repo. image

If you have any suggestions , pls do share

pamelafox commented 1 year ago

I am using a GitHub action workflow, not ADO pipeline, which you can see in my attempted PR: https://github.com/Azure-Samples/azure-search-openai-demo/pull/444/files