search

microsoft / sfs-client

Simple File Solution (SFS) Client
MIT License
15 stars 13 forks source link

Setup.ps1 operation fails on Installing C++ Build Tools if already installed. #197

Closed niuxw-msft closed 2 months ago

niuxw-msft commented 7 months ago

Describe the bug Setup.ps1 operation fails on Installing C++ Build Tools if already installed.

image

To Reproduce Steps to reproduce the behavior:

  1. Run the Setup script '.\scripts\Setup.ps1'
  2. See the failure

Expected behavior Should be successful.

Additional context The Visual Studio Enterprise 2022 is already installed on my machine. I recalled that the first time I run the script, a VC Build Tool was installed successfully (It showed in Visual Studio Installer with Visual Studio Enterprise). But I manually deleted the tool as it is duplicated than the Visual Studio Enterprise. I hit the issue after then.

arthuraraujo-msft commented 7 months ago

It looks like we could try to auto detect if build tools are installed somehow. And given that we wouldn't need the -NoBuildTools switch We don't have a hard constraint for the build tools version

arthuraraujo-msft commented 6 months ago

@niuxw-msft could you take a look at this issue?

arthuraraujo-msft commented 2 months ago

Had some trouble with this and fixed it. Will be putting up a PR.