search

microsoft / snmalloc

Message passing based allocator
MIT License
1.58k stars 109 forks source link

DNM: github/morello: catch up to 2023.11 #653

Closed nwf-msr closed 2 months ago

nwf-msr commented 11 months ago

The 2023.11 ports tree no longer has llvm-localbase depend on llvm, so go ahead and install that too.

CI on this PR will make sure that it still works with 2022.12, and I'll go manually test that it works on 2023.11, too.

nwf-msr commented 11 months ago

Ah, well, so much for easy. CheriBSD 2023.11 does not expose old jemalloc experimental API symbols (specifically allocm, nallocm, sallocm, dallocm, rallocm). (If you want the actual failure, it's over at https://github.com/microsoft/snmalloc/actions/runs/7415212980/job/20177910989 .) Jess conveys that they have even been removed from upstream jemalloc and are kept by FreeBSD for compatibility. How should we proceed?

Tagging @davidchisnall for opinions.

davidchisnall commented 11 months ago

FreeBSD has backports of them because someone thought it was a good idea to make them part of the libc API. I added them in snmalloc so that my snmalloc-in-libc branch can be ABI preserving. I’m not sure why CheriBSD removed them, since I’m not sure upstream FreeBSD has that option without a libc SONAME bump (which no one wants) and doesn’t need to do it (since we have compat implementations).

The test is toggled by this line:

https://github.com/microsoft/snmalloc/blob/640cacf90ee83697d082c8fc758f0ea762e5e27a/src/test/func/jemalloc/jemalloc.cc#L19

We run it against libc on FreeBSD to make sure that our implementations of their APIs have the same behaviour as libc. We probably need an option to disable that if CheriBSD is happy breaking ABIs.

nwf-msr commented 10 months ago

Bah. The easy thing doesn't seem to have worked. https://github.com/microsoft/snmalloc/actions/runs/7425654462/job/20207760770

nwf-msr commented 2 months ago

The Morello Cluster that would have run these CI jobs is no more. I should raise another PR to remove them, and we should figure out if the CL would be willing to run some CI on their Jenkins setup for us.