UI nits from WinUI Controlsv2

zadjii-msft commented 2 years ago

In Terminal 1.13 we updated our version of WinUI to closer align with the Windows 11 styles. (in technical terms, we updated to ControlsV2). This had a variety of minor visual artifacts associated with it:

[x] #12395
- upstream discussion: https://github.com/microsoft/microsoft-ui-xaml/issues/6684
- potential workaround: https://github.com/microsoft/terminal/issues/9218
- fixed in #12608
[ ] New Tab icons aren't quite the right size: https://github.com/microsoft/terminal/issues/12395#issuecomment-1030874694
[x] #12398
- Upstream: https://github.com/microsoft/microsoft-ui-xaml/issues/6685
[x] #12350
[ ] #12388
- Also includes:
- [ ] #13285
- [ ] #13068
- [x] #9775
- [x] #13428
[x] Colors are inconsistent between active tab, nav view, and tab content
- But actually, that's just how it is in Xaml Controls Gallery too:
[x] #12574
[x] #13495

Relevant PRS:

12241
11720
12144
12287
12326
12374
12376
12381

vefatica commented 2 years ago

Now the release version is suffering. Black seems a bad choice for the background of the tab portion of the window. The icon for opening the dropdown menu (down arrowhead?) is too small.

DHowett commented 2 years ago

Unfortunately for us, those colors were chosen under official guidance from the UI folks.

vefatica commented 2 years ago

How about the size of the symbol on the dropdown menu's icon? It's not the same size as the symbols on the icons for new tab, minimize, maximize, and close (compare to previous UI version). It just looks like a mistake!

Tropix126 commented 2 years ago

Could the padding with the settings UI be increased? On larger window sizes it begins to look really cramped with almost no space between the title and content, and also seems to be inconsistent with other WinUI apps.

Current