search

microsoft / testfx

MSTest framework and adapter
MIT License
779 stars 259 forks source link

Logging messages to be localized #4133

Open Youssef1313 opened 6 days ago

Youssef1313 commented 6 days ago

Hang dump (#4145)

https://github.com/microsoft/testfx/blob/e4c08367b3203ef678645d9ce54816c838709cd7/src/Platform/Microsoft.Testing.Extensions.HangDump/HangDumpProcessLifetimeHandler.cs#L126

https://github.com/microsoft/testfx/blob/e4c08367b3203ef678645d9ce54816c838709cd7/src/Platform/Microsoft.Testing.Extensions.HangDump/HangDumpProcessLifetimeHandler.cs#L327

https://github.com/microsoft/testfx/blob/e4c08367b3203ef678645d9ce54816c838709cd7/src/Platform/Microsoft.Testing.Extensions.HangDump/HangDumpProcessLifetimeHandler.cs#L353

MTP configurations

https://github.com/microsoft/testfx/blob/e4c08367b3203ef678645d9ce54816c838709cd7/src/Platform/Microsoft.Testing.Platform/Configurations/JsonConfigurationProvider.cs#L37

https://github.com/microsoft/testfx/blob/e4c08367b3203ef678645d9ce54816c838709cd7/src/Platform/Microsoft.Testing.Platform/Configurations/JsonConfigurationProvider.cs#L41

MTP hosts

https://github.com/microsoft/testfx/blob/e4c08367b3203ef678645d9ce54816c838709cd7/src/Platform/Microsoft.Testing.Platform/Hosts/ConsoleTestHost.cs#L76

https://github.com/microsoft/testfx/blob/e4c08367b3203ef678645d9ce54816c838709cd7/src/Platform/Microsoft.Testing.Platform/Hosts/ConsoleTestHost.cs#L99

https://github.com/microsoft/testfx/blob/e4c08367b3203ef678645d9ce54816c838709cd7/src/Platform/Microsoft.Testing.Platform/Hosts/ConsoleTestHost.cs#L112

https://github.com/microsoft/testfx/blob/e4c08367b3203ef678645d9ce54816c838709cd7/src/Platform/Microsoft.Testing.Platform/Hosts/TestHostControllersTestHost.cs#L328

MTP requests

https://github.com/microsoft/testfx/blob/e4c08367b3203ef678645d9ce54816c838709cd7/src/Platform/Microsoft.Testing.Platform/Requests/TestHostTestFrameworkInvoker.cs#L41 (Related to AB#2275339)

Evangelink commented 3 days ago

@Youssef1313 The logs should remain unlocalized as they are technical diagnostic info. If we start to localize them, we will have hard time diagnostising user issues.

For the issue with Test Explorer, I think we instead need to review the current logic as we probably don't want the logs to be brought up to TE.