microsoft / vscode-azureapicenter

MIT License
10 stars 6 forks source link

feat: remove azure account extension depends #192

Closed wenytang-ms closed 4 days ago

wenytang-ms commented 1 week ago

image Animation

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 44.63190% with 722 lines in your changes missing coverage. Please review.

Project coverage is 40.50%. Comparing base (ed9873f) to head (c8a688b). Report is 1 commits behind head on dev.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/microsoft/vscode-azureapicenter/pull/192/graphs/tree.svg?width=650&height=150&src=pr&token=TIJgHIZNDD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft)](https://app.codecov.io/gh/microsoft/vscode-azureapicenter/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) ```diff @@ Coverage Diff @@ ## dev #192 +/- ## ========================================== + Coverage 39.52% 40.50% +0.97% ========================================== Files 71 78 +7 Lines 3696 4935 +1239 Branches 109 159 +50 ========================================== + Hits 1461 1999 +538 - Misses 2234 2935 +701 Partials 1 1 ``` | [Files](https://app.codecov.io/gh/microsoft/vscode-azureapicenter/pull/192?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [src/azure/ApiCenter/ApiCenterRestAPIs.ts](https://app.codecov.io/gh/microsoft/vscode-azureapicenter/pull/192?src=pr&el=tree&filepath=src%2Fazure%2FApiCenter%2FApiCenterRestAPIs.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-c3JjL2F6dXJlL0FwaUNlbnRlci9BcGlDZW50ZXJSZXN0QVBJcy50cw==) | `100.00% <100.00%> (ø)` | | | [src/azure/azureLogin/authTypes.ts](https://app.codecov.io/gh/microsoft/vscode-azureapicenter/pull/192?src=pr&el=tree&filepath=src%2Fazure%2FazureLogin%2FauthTypes.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-c3JjL2F6dXJlL2F6dXJlTG9naW4vYXV0aFR5cGVzLnRz) | `100.00% <100.00%> (ø)` | | | [src/constants.ts](https://app.codecov.io/gh/microsoft/vscode-azureapicenter/pull/192?src=pr&el=tree&filepath=src%2Fconstants.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-c3JjL2NvbnN0YW50cy50cw==) | `100.00% <100.00%> (ø)` | | | [src/extensionVariables.ts](https://app.codecov.io/gh/microsoft/vscode-azureapicenter/pull/192?src=pr&el=tree&filepath=src%2FextensionVariables.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-c3JjL2V4dGVuc2lvblZhcmlhYmxlcy50cw==) | `100.00% <100.00%> (ø)` | | | [src/test/unit/commands/exportApi.test.ts](https://app.codecov.io/gh/microsoft/vscode-azureapicenter/pull/192?src=pr&el=tree&filepath=src%2Ftest%2Funit%2Fcommands%2FexportApi.test.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-c3JjL3Rlc3QvdW5pdC9jb21tYW5kcy9leHBvcnRBcGkudGVzdC50cw==) | `90.14% <100.00%> (ø)` | | | [src/test/unit/commands/generateApiFromCode.test.ts](https://app.codecov.io/gh/microsoft/vscode-azureapicenter/pull/192?src=pr&el=tree&filepath=src%2Ftest%2Funit%2Fcommands%2FgenerateApiFromCode.test.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-c3JjL3Rlc3QvdW5pdC9jb21tYW5kcy9nZW5lcmF0ZUFwaUZyb21Db2RlLnRlc3QudHM=) | `98.21% <100.00%> (ø)` | | | [src/test/unit/commands/generateHttpFile.test.ts](https://app.codecov.io/gh/microsoft/vscode-azureapicenter/pull/192?src=pr&el=tree&filepath=src%2Ftest%2Funit%2Fcommands%2FgenerateHttpFile.test.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-c3JjL3Rlc3QvdW5pdC9jb21tYW5kcy9nZW5lcmF0ZUh0dHBGaWxlLnRlc3QudHM=) | `100.00% <100.00%> (ø)` | | | [src/test/unit/commands/registerApi.test.ts](https://app.codecov.io/gh/microsoft/vscode-azureapicenter/pull/192?src=pr&el=tree&filepath=src%2Ftest%2Funit%2Fcommands%2FregisterApi.test.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-c3JjL3Rlc3QvdW5pdC9jb21tYW5kcy9yZWdpc3RlckFwaS50ZXN0LnRz) | `100.00% <100.00%> (ø)` | | | [...nds/registerApiSubCommands/registerViaCICD.test.ts](https://app.codecov.io/gh/microsoft/vscode-azureapicenter/pull/192?src=pr&el=tree&filepath=src%2Ftest%2Funit%2Fcommands%2FregisterApiSubCommands%2FregisterViaCICD.test.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-c3JjL3Rlc3QvdW5pdC9jb21tYW5kcy9yZWdpc3RlckFwaVN1YkNvbW1hbmRzL3JlZ2lzdGVyVmlhQ0lDRC50ZXN0LnRz) | `98.83% <100.00%> (ø)` | | | [src/uiStrings.ts](https://app.codecov.io/gh/microsoft/vscode-azureapicenter/pull/192?src=pr&el=tree&filepath=src%2FuiStrings.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-c3JjL3VpU3RyaW5ncy50cw==) | `100.00% <100.00%> (ø)` | | | ... and [10 more](https://app.codecov.io/gh/microsoft/vscode-azureapicenter/pull/192?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | |
wenytang-ms commented 4 days ago

Overall looks good. Just need to check if there are any more strings needed to put into uiStrings.ts

@formulahendry The ui string all updated, please review again