search

microsoft / vscode-azureresourcegroups

VS Code extension for managing Azure resources.
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azureresourcegroups
MIT License
52 stars 28 forks source link

Refactor VS Code auth #616

Closed alexweininger closed 1 year ago

alexweininger commented 1 year ago

Refactor VS Code auth portion of the vscode.dev work to hide the auth implementation details from the rest of the code. Now both the VS Code auth (used in vscode.dev) and the Azure Account API auth are shoehorned into a common interface.

This makes it easier to adapt for testing purposes and is similar to what I've done in https://github.com/microsoft/vscode-azureresourcegroups/pull/563

nturinski commented 1 year ago

I think you need to revert some of the package.json changes.

This error message: 12 verbose stack Invalid: lock file's @microsoft/vscode-azext-utils@0.5.1 does not satisfy @microsoft/vscode-azext-utils@0.4.3-alpha is preventing it from building.

You can use 0.5.2-alpha.0. Should have all the changes of 0.5.1 + the dev stuff required.

alexweininger commented 1 year ago

What's going on with this build? 😢

nturinski commented 1 year ago

I've never seen this error before:

C:\Windows\system32\cmd.exe /D /S /C "C:\hostedtoolcache\windows\node\14.21.3\x64\npm.cmd ci"
npm ERR! assert not accessible from @microsoft/vscode-azext-dev
nturinski commented 1 year ago

So annoying... I couldn't test it because of the dependency on the Azure Accounts extension in the package.json. I can manually change it, but should definitely do something about it on the scripting level.

Anyway, get these two errors when testing it out:

Cannot read properties of undefined (reading 'length')
this.subscriptionResultsTask is not a function