search

microsoft / vscode-azureresourcegroups

VS Code extension for managing Azure resources.
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azureresourcegroups
MIT License
52 stars 28 forks source link

Refresh subscription instead of group #618

Closed alexweininger closed 1 year ago

alexweininger commented 1 year ago

Fixes #617

alexweininger commented 1 year ago

Could we make the refresh implementation different on the node itself rather than having this weird edge case in the command defintion?

Like, if you call GroupingTreeItem's refresh, it's implementation will handle passing up the subscription/parent node? Or do we not have that capability anymore?

We haven't done it that way for v2, however that's probably a good approach.

nturinski commented 1 year ago

Is it possible to do that now or should I just go ahead and approve this for merge, and we can leave an issue for it later?

alexweininger commented 1 year ago

Is it possible to do that now or should I just go ahead and approve this for merge, and we can leave an issue for it later?

I will change it sometime today (hopefully). 😄

alexweininger commented 1 year ago

Since this is sorta a special case, I think for now this implementation is fine. None of the solutions I have feel right since it's just for this one edge case.

nturinski commented 1 year ago

Alright, definitely something to keep in mind when we convert a hefty boy like Functions.