microsoft / vscode-cmake-tools

CMake integration in Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=vector-of-bool.cmake-tools
MIT License
1.48k stars 456 forks source link

Add guard against reloading a file that's not a variants file #3878

Closed jophippe closed 4 months ago

jophippe commented 4 months ago

This change addresses item #3727

The following changes are proposed:

Other Notes/Information

Ideally, we would figure out why the reload variants functionality would be given a path other than a variants file, since our file watcher should only be watching for variants files, but I haven't figured that out yet

jophippe commented 4 months ago

@gcampbell-msft Okay, I made a 1.19 section in the changelog and moved both my bugfixes into it. Does anything else need to be moved into the 1.19 section?

gcampbell-msft commented 4 months ago

@gcampbell-msft Okay, I made a 1.19 section in the changelog and moved both my bugfixes into it. Does anything else need to be moved into the 1.19 section?

I think that's it