microsoft / vscode-generator-code

Visual Studio Code extension generator
Other
1.29k stars 222 forks source link

Generator produces dependency on non-existing dependency "@types/vscode": "^1.70.0" #365

Closed shoffmeister closed 2 years ago

shoffmeister commented 2 years ago

Following the official Microsoft tutorial at https://code.visualstudio.com/api/get-started/your-first-extension yields a package.json which, at the time of this writing (see submission timestamp), contains:

  "devDependencies": {
    "@types/vscode": "^1.70.0",

Trying an npm install with that fails as I am writing this.

Obviously 1.70.0 is my current (released) vscode version (auto-upgraded via the Microsoft rpm package repo), but there is no 1.70.0 type package at https://www.npmjs.com/package/@types/vscode as I am writing this

It seems as if there is a problem

Note that as I am writing this, the npm repo has 1.69.1 as the latest version of the types - and I am aware of there having been an 1.69.2 release of vscode proper, so there is one more version inconsistency, and I cannot tell what is right or wrong.

In any event, running through the Microsoft tutorial for the first extension should produce code that is guaranteed to compile and run, i.e. all dependencies should resolve at all times (perhaps worthwhile adding some kind of CI for the generator with an E2E test, given how aggressively it tracks the vscode version?)

shoffmeister commented 2 years ago

Work-around: 1.70.0 -> 1.69.1 (and crank down the dependency on the engines too)

bpasero commented 2 years ago

The version is out now.