search

microsoft / vscode-jupyter

VS Code Jupyter extension
https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter
MIT License
1.3k stars 294 forks source link

Restart icon is not themeable #16118

Open miguelsolorio opened 1 month ago

miguelsolorio commented 1 month ago

Applies To

What happened?

Nit: toolbar is contributing an SVG that is not themeable and stands out in themes:

Image

Suggestion to remove this icon path: https://github.com/microsoft/vscode-jupyter/blob/4a13fca8f5293815e34be98b5f5a0465a007dcdf/package.json#L602-L605

and replace with using native icons:

"icon": "$(restart)"

This also allows product icon themes to customize this icon & color:

Image

Version: 1.94.2 Commit: 384ff7382de624fb94dbaf6da11977bba1ecd427 Date: 2024-10-09T16:08:44.566Z Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Code/1.94.2 Chrome/124.0.6367.243 Electron/30.5.1 Safari/537.36

VS Code Version

1.94.2

Jupyter Extension Version

v2024.9.1

Jupyter logs

No response

Coding Language and Runtime Version

No response

Language Extension Version (if applicable)

No response

Anaconda Version (if applicable)

No response

Running Jupyter locally or remotely?

None

Yoyokrazy commented 4 weeks ago

potentially related when label strategy is dynamic:

Image