search

microsoft / vscode-l10n

MIT License
62 stars 12 forks source link

import-xlf command should output package.nls.[language].json loc files to root, not --output-dir #164

Open jruales opened 6 months ago

jruales commented 6 months ago

In @vscode/l10n-dev, the import-xlf command takes a parameter --output-dir, which per the current logic sets the output directory for both bundle.[language].json and package.nls.[language].json.

However, this doesn't accommodate the case from the official l10n-sample, where you can see that the file package.nls.[language].json lives in the root directory, whereas the file bundle.[language].json lives in the ./l10n/ directory. From what I understand, the package.nls.[language].json files must live in the same directory as package.nls.json and package.json, regardless of the value of the l10n parameter specified inside of package.json, so why does import-xlf move package.nls.[language].json to a folder where it won't be recognized?

TylerLeonhardt commented 6 months ago

Yeah these should just go to wherever the package.json is.